Skip to content
Snippets Groups Projects
Commit ee47e355 authored by buczekp's avatar buczekp
Browse files

[LMS-1924] added hostUrl to DataStore DTO to simplify codebase

SVN: 19051
parent 2c1afbdd
No related branches found
No related tags found
No related merge requests found
...@@ -604,6 +604,7 @@ public class DatasetLister extends AbstractLister implements IDatasetLister ...@@ -604,6 +604,7 @@ public class DatasetLister extends AbstractLister implements IDatasetLister
{ {
DataStore result = new DataStore(); DataStore result = new DataStore();
setCode(result, codeRecord); setCode(result, codeRecord);
result.setHostUrl(codeRecord.download_url);
String downloadUrl = DataStoreTranslator.translateDownloadUrl(codeRecord.download_url); String downloadUrl = DataStoreTranslator.translateDownloadUrl(codeRecord.download_url);
result.setDownloadUrl(downloadUrl); result.setDownloadUrl(downloadUrl);
return result; return result;
......
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
package ch.systemsx.cisd.openbis.generic.shared.basic.dto; package ch.systemsx.cisd.openbis.generic.shared.basic.dto;
/** /**
* @author Izabela Adamczyk * @author Izabela Adamczyk
*/ */
...@@ -26,6 +25,8 @@ public class DataStore extends Code<DataStore> ...@@ -26,6 +25,8 @@ public class DataStore extends Code<DataStore>
private String downloadUrl; private String downloadUrl;
private String hostUrl;
public String getDownloadUrl() public String getDownloadUrl()
{ {
return downloadUrl; return downloadUrl;
...@@ -36,4 +37,14 @@ public class DataStore extends Code<DataStore> ...@@ -36,4 +37,14 @@ public class DataStore extends Code<DataStore>
this.downloadUrl = downloadUrl; this.downloadUrl = downloadUrl;
} }
public String getHostUrl()
{
return hostUrl;
}
public void setHostUrl(String hostUrl)
{
this.hostUrl = hostUrl;
}
} }
...@@ -30,6 +30,7 @@ public class DataStoreTranslator ...@@ -30,6 +30,7 @@ public class DataStoreTranslator
{ {
DataStore dataStore = new DataStore(); DataStore dataStore = new DataStore();
String downloadUrl = dataStorePE.getDownloadUrl(); String downloadUrl = dataStorePE.getDownloadUrl();
dataStore.setHostUrl(downloadUrl);
downloadUrl = translateDownloadUrl(downloadUrl); downloadUrl = translateDownloadUrl(downloadUrl);
dataStore.setDownloadUrl(downloadUrl); dataStore.setDownloadUrl(downloadUrl);
dataStore.setCode(dataStorePE.getCode()); dataStore.setCode(dataStorePE.getCode());
......
...@@ -476,6 +476,7 @@ public final class CommonClientServiceTest extends AbstractClientServiceTest ...@@ -476,6 +476,7 @@ public final class CommonClientServiceTest extends AbstractClientServiceTest
assertEquals(1, list.size()); assertEquals(1, list.size());
ExternalData data = list.get(0); ExternalData data = list.get(0);
// assertEquals(code, data.getCode()); // assertEquals(code, data.getCode());
assertEquals(DATA_STORE_BASE_URL, data.getDataStore().getHostUrl());
assertEquals(DATA_STORE_BASE_URL + "/" + DATA_STORE_SERVER_WEB_APPLICATION_NAME, data assertEquals(DATA_STORE_BASE_URL + "/" + DATA_STORE_SERVER_WEB_APPLICATION_NAME, data
.getDataStore().getDownloadUrl()); .getDataStore().getDownloadUrl());
assertEquals("PNG", data.getFileFormatType().getCode()); assertEquals("PNG", data.getFileFormatType().getCode());
......
...@@ -35,13 +35,13 @@ import ch.systemsx.cisd.openbis.generic.shared.dto.ExperimentPE; ...@@ -35,13 +35,13 @@ import ch.systemsx.cisd.openbis.generic.shared.dto.ExperimentPE;
import ch.systemsx.cisd.openbis.generic.shared.dto.ExperimentTypePE; import ch.systemsx.cisd.openbis.generic.shared.dto.ExperimentTypePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.ExternalDataPE; import ch.systemsx.cisd.openbis.generic.shared.dto.ExternalDataPE;
import ch.systemsx.cisd.openbis.generic.shared.dto.FileFormatTypePE; import ch.systemsx.cisd.openbis.generic.shared.dto.FileFormatTypePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.SpacePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.InvalidationPE; import ch.systemsx.cisd.openbis.generic.shared.dto.InvalidationPE;
import ch.systemsx.cisd.openbis.generic.shared.dto.LocatorTypePE; import ch.systemsx.cisd.openbis.generic.shared.dto.LocatorTypePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.PersonPE; import ch.systemsx.cisd.openbis.generic.shared.dto.PersonPE;
import ch.systemsx.cisd.openbis.generic.shared.dto.ProjectPE; import ch.systemsx.cisd.openbis.generic.shared.dto.ProjectPE;
import ch.systemsx.cisd.openbis.generic.shared.dto.SamplePE; import ch.systemsx.cisd.openbis.generic.shared.dto.SamplePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.SampleTypePE; import ch.systemsx.cisd.openbis.generic.shared.dto.SampleTypePE;
import ch.systemsx.cisd.openbis.generic.shared.dto.SpacePE;
/** /**
* @author Franz-Josef Elmer * @author Franz-Josef Elmer
...@@ -122,6 +122,7 @@ public class ExternalDataTranslatorTest extends AssertJUnit ...@@ -122,6 +122,7 @@ public class ExternalDataTranslatorTest extends AssertJUnit
ExternalData externalData = ExternalData externalData =
ExternalDataTranslator.translate(externalDataPE, BASE_INDEX_URL); ExternalDataTranslator.translate(externalDataPE, BASE_INDEX_URL);
assertEquals(DOWNLOAD_URL, externalData.getDataStore().getHostUrl());
assertEquals(DOWNLOAD_URL + "/" + DATA_STORE_SERVER_WEB_APPLICATION_NAME, externalData assertEquals(DOWNLOAD_URL + "/" + DATA_STORE_SERVER_WEB_APPLICATION_NAME, externalData
.getDataStore().getDownloadUrl()); .getDataStore().getDownloadUrl());
assertEquals("code", externalData.getCode()); assertEquals("code", externalData.getCode());
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment