fix: - 'LoginWidget' should reset its fields.

SVN: 8829

authentication/source/java/ch/systemsx/cisd/authentication/DummyAuthenticationService.java

@@ -38,14 +38,14 @@ public final class DummyAuthenticationService implements IAuthenticationService
     }
 
     /**
-     * Always returns <code>true</code>, meaning that the login was successfull.
+     * Always returns <code>true</code>, meaning that the login was successful.
      */
-    public final boolean authenticateUser(String applicationToken, String user, String password)
+    public final boolean authenticateUser(final String applicationToken, final String user, final String password)
     {
         return true;
     }
 
-    public final Principal getPrincipal(String applicationToken, String user)
+    public final Principal getPrincipal(final String applicationToken, final String user)
     {
         return new Principal(user, "John", "Doe", "franz-josef.elmer@systemsx.ch");
     }

openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/LoginWidget.java

@@ -162,11 +162,18 @@ public class LoginWidget extends VerticalPanel
         }
     }
 
+    public final void resetFields()
+    {
+        userField.reset();
+        passwordField.reset();
+        button.enable();
+    }
+
     //
     // Helper classes
     //
 
-    public static final class LoginCallback extends AbstractAsyncCallback<SessionContext>
+    public final class LoginCallback extends AbstractAsyncCallback<SessionContext>
     {
         private LoginCallback(final IViewContext<IGenericClientServiceAsync> viewContext)
         {
@@ -177,6 +184,12 @@ public class LoginWidget extends VerticalPanel
         // AbstractAsyncCallback
         //
 
+        @Override
+        protected final void finishOnFailure(final Throwable caught)
+        {
+            resetFields();
+        }
+
         @Override
         public final void process(final SessionContext sessionContext)
         {
@@ -200,6 +213,7 @@ public class LoginWidget extends VerticalPanel
             {
                 viewContext.getPageController().reload();
             }
+            resetFields();
         }
     }
 }

openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/sample_browser/SampleBrowserGrid.java

@@ -390,7 +390,7 @@ public final class SampleBrowserGrid extends LayoutContainer
                             @Override
                             protected final void finishOnFailure(final Throwable caught)
                             {
-                                // callback.onFailure(caught);
+                                callback.onFailure(caught);
                             }
                         };
                 }