Skip to content
Snippets Groups Projects
Commit a5839b91 authored by brinn's avatar brinn
Browse files

change: move constant to DatamoverConstants

SVN: 7443
parent 83e82ca6
No related branches found
No related tags found
No related merge requests found
...@@ -28,4 +28,7 @@ public class DatamoverConstants ...@@ -28,4 +28,7 @@ public class DatamoverConstants
public static final String RSYNC_PASSWORD_FILE_INCOMING = "etc/rsync_incoming.passwd"; public static final String RSYNC_PASSWORD_FILE_INCOMING = "etc/rsync_incoming.passwd";
public static final String RSYNC_PASSWORD_FILE_OUTGOING = "etc/rsync_outgoing.passwd"; public static final String RSYNC_PASSWORD_FILE_OUTGOING = "etc/rsync_outgoing.passwd";
public static final int IGNORED_ERROR_COUNT_BEFORE_NOTIFICATION = 3;
} }
...@@ -33,6 +33,7 @@ import ch.systemsx.cisd.common.logging.LogLevel; ...@@ -33,6 +33,7 @@ import ch.systemsx.cisd.common.logging.LogLevel;
import ch.systemsx.cisd.common.utilities.ITimeProvider; import ch.systemsx.cisd.common.utilities.ITimeProvider;
import ch.systemsx.cisd.common.utilities.StoreItem; import ch.systemsx.cisd.common.utilities.StoreItem;
import ch.systemsx.cisd.common.utilities.SystemTimeProvider; import ch.systemsx.cisd.common.utilities.SystemTimeProvider;
import ch.systemsx.cisd.datamover.DatamoverConstants;
import ch.systemsx.cisd.datamover.filesystem.intf.IFileStore; import ch.systemsx.cisd.datamover.filesystem.intf.IFileStore;
import ch.systemsx.cisd.datamover.intf.ITimingParameters; import ch.systemsx.cisd.datamover.intf.ITimingParameters;
...@@ -51,8 +52,6 @@ import ch.systemsx.cisd.datamover.intf.ITimingParameters; ...@@ -51,8 +52,6 @@ import ch.systemsx.cisd.datamover.intf.ITimingParameters;
*/ */
public class QuietPeriodFileFilter implements IStoreItemFilter public class QuietPeriodFileFilter implements IStoreItemFilter
{ {
private static final int IGNORED_ERROR_COUNT_BEFORE_NOTIFICATION = 3;
@Private @Private
static final int CLEANUP_TO_QUIET_PERIOD_RATIO = 10; static final int CLEANUP_TO_QUIET_PERIOD_RATIO = 10;
...@@ -67,12 +66,12 @@ public class QuietPeriodFileFilter implements IStoreItemFilter ...@@ -67,12 +66,12 @@ public class QuietPeriodFileFilter implements IStoreItemFilter
private final static Logger machineLog = private final static Logger machineLog =
LogFactory.getLogger(LogCategory.MACHINE, QuietPeriodFileFilter.class); LogFactory.getLogger(LogCategory.MACHINE, QuietPeriodFileFilter.class);
private final static Logger notifyLog = private final static Logger notificationLog =
LogFactory.getLogger(LogCategory.NOTIFY, QuietPeriodFileFilter.class); LogFactory.getLogger(LogCategory.NOTIFY, QuietPeriodFileFilter.class);
private final ConditionalNotificationLogger conditionalNotifyLog = private final ConditionalNotificationLogger conditionalNotificationLog =
new ConditionalNotificationLogger(machineLog, notifyLog, new ConditionalNotificationLogger(machineLog, notificationLog,
IGNORED_ERROR_COUNT_BEFORE_NOTIFICATION); DatamoverConstants.IGNORED_ERROR_COUNT_BEFORE_NOTIFICATION);
private final long quietPeriodMillis; private final long quietPeriodMillis;
...@@ -173,13 +172,13 @@ public class QuietPeriodFileFilter implements IStoreItemFilter ...@@ -173,13 +172,13 @@ public class QuietPeriodFileFilter implements IStoreItemFilter
final StatusWithResult<Long> status = fileStore.lastChanged(item, oldLastChanged); final StatusWithResult<Long> status = fileStore.lastChanged(item, oldLastChanged);
if (status.isError()) if (status.isError())
{ {
conditionalNotifyLog.log(LogLevel.ERROR, String.format( conditionalNotificationLog.log(LogLevel.ERROR, String.format(
"Cannot obtain \"last changed\" status of item '%s' in store '%s': %s", "Cannot obtain \"last changed\" status of item '%s' in store '%s': %s",
item, fileStore, status.tryGetErrorMessage())); item, fileStore, status.tryGetErrorMessage()));
return false; return false;
} else } else
{ {
conditionalNotifyLog.reset(null); conditionalNotificationLog.reset(null);
} }
final long newLastChanged = status.tryGetResult(); final long newLastChanged = status.tryGetResult();
if (newLastChanged != oldLastChanged) if (newLastChanged != oldLastChanged)
...@@ -219,10 +218,10 @@ public class QuietPeriodFileFilter implements IStoreItemFilter ...@@ -219,10 +218,10 @@ public class QuietPeriodFileFilter implements IStoreItemFilter
if (status.isError() == false) if (status.isError() == false)
{ {
pathMap.put(item, new PathCheckRecord(now, status.tryGetResult())); pathMap.put(item, new PathCheckRecord(now, status.tryGetResult()));
conditionalNotifyLog.reset(null); conditionalNotificationLog.reset(null);
} else } else
{ {
conditionalNotifyLog.log(LogLevel.ERROR, String.format( conditionalNotificationLog.log(LogLevel.ERROR, String.format(
"Cannot obtain \"last changed\" status of item '%s' in store '%s': %s", "Cannot obtain \"last changed\" status of item '%s' in store '%s': %s",
item, fileStore, status.tryGetErrorMessage())); item, fileStore, status.tryGetErrorMessage()));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment