Skip to content
Snippets Groups Projects
Commit a129ef97 authored by tpylak's avatar tpylak
Browse files

LMS-647 remove flush statements from openbis project

SVN: 8959
parent 19ce8a7d
No related branches found
No related tags found
No related merge requests found
...@@ -124,7 +124,6 @@ final class DatabaseInstanceDAO extends AbstractDAO implements IDatabaseInstance ...@@ -124,7 +124,6 @@ final class DatabaseInstanceDAO extends AbstractDAO implements IDatabaseInstance
databaseInstancePE.setUuid(CodeConverter.tryToDatabase(databaseInstancePE.getUuid())); databaseInstancePE.setUuid(CodeConverter.tryToDatabase(databaseInstancePE.getUuid()));
final HibernateTemplate hibernateTemplate = getHibernateTemplate(); final HibernateTemplate hibernateTemplate = getHibernateTemplate();
hibernateTemplate.update(databaseInstancePE); hibernateTemplate.update(databaseInstancePE);
hibernateTemplate.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
operationLog.info(String.format("UPDATE: database instance '%s'.", databaseInstancePE)); operationLog.info(String.format("UPDATE: database instance '%s'.", databaseInstancePE));
...@@ -163,7 +162,5 @@ final class DatabaseInstanceDAO extends AbstractDAO implements IDatabaseInstance ...@@ -163,7 +162,5 @@ final class DatabaseInstanceDAO extends AbstractDAO implements IDatabaseInstance
databaseInstance.setUuid(UuidUtil.generateUUID()); databaseInstance.setUuid(UuidUtil.generateUUID());
final HibernateTemplate template = getHibernateTemplate(); final HibernateTemplate template = getHibernateTemplate();
template.save(databaseInstance); template.save(databaseInstance);
template.flush();
} }
} }
...@@ -139,7 +139,6 @@ final class GroupDAO extends AbstractDAO implements IGroupDAO ...@@ -139,7 +139,6 @@ final class GroupDAO extends AbstractDAO implements IGroupDAO
group.setCode(CodeConverter.tryToDatabase(group.getCode())); group.setCode(CodeConverter.tryToDatabase(group.getCode()));
final HibernateTemplate template = getHibernateTemplate(); final HibernateTemplate template = getHibernateTemplate();
template.save(group); template.save(group);
template.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
operationLog.info(String.format("ADD: group '%s'.", group)); operationLog.info(String.format("ADD: group '%s'.", group));
......
...@@ -68,7 +68,6 @@ public final class PersonDAO extends AbstractDAO implements IPersonDAO ...@@ -68,7 +68,6 @@ public final class PersonDAO extends AbstractDAO implements IPersonDAO
final HibernateTemplate template = getHibernateTemplate(); final HibernateTemplate template = getHibernateTemplate();
template.save(person); template.save(person);
template.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
operationLog.info(String.format("ADD: person '%s'.", person)); operationLog.info(String.format("ADD: person '%s'.", person));
...@@ -82,7 +81,6 @@ public final class PersonDAO extends AbstractDAO implements IPersonDAO ...@@ -82,7 +81,6 @@ public final class PersonDAO extends AbstractDAO implements IPersonDAO
validatePE(person); validatePE(person);
final HibernateTemplate template = getHibernateTemplate(); final HibernateTemplate template = getHibernateTemplate();
template.update(person); template.update(person);
template.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
operationLog.info(String.format("UPDATE: person '%s'.", person)); operationLog.info(String.format("UPDATE: person '%s'.", person));
......
...@@ -91,7 +91,6 @@ public final class RoleAssignmentDAO extends AbstractDAO implements IRoleAssignm ...@@ -91,7 +91,6 @@ public final class RoleAssignmentDAO extends AbstractDAO implements IRoleAssignm
final HibernateTemplate hibernateTemplate = getHibernateTemplate(); final HibernateTemplate hibernateTemplate = getHibernateTemplate();
hibernateTemplate.save(roleAssignment); hibernateTemplate.save(roleAssignment);
hibernateTemplate.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
operationLog.info(String.format("ADD: role assignment '%s'.", roleAssignment)); operationLog.info(String.format("ADD: role assignment '%s'.", roleAssignment));
......
...@@ -93,7 +93,6 @@ public class SampleDAO extends AbstractDAO implements ISampleDAO ...@@ -93,7 +93,6 @@ public class SampleDAO extends AbstractDAO implements ISampleDAO
final HibernateTemplate hibernateTemplate = getHibernateTemplate(); final HibernateTemplate hibernateTemplate = getHibernateTemplate();
hibernateTemplate.save(sample); hibernateTemplate.save(sample);
hibernateTemplate.flush();
if (operationLog.isInfoEnabled()) if (operationLog.isInfoEnabled())
{ {
......
...@@ -25,6 +25,7 @@ import static org.testng.AssertJUnit.fail; ...@@ -25,6 +25,7 @@ import static org.testng.AssertJUnit.fail;
import java.util.List; import java.util.List;
import org.hibernate.classic.Session;
import org.testng.annotations.Test; import org.testng.annotations.Test;
import ch.systemsx.cisd.openbis.generic.server.business.bo.util.SampleOwner; import ch.systemsx.cisd.openbis.generic.server.business.bo.util.SampleOwner;
...@@ -74,9 +75,13 @@ public final class SampleDAOTest extends AbstractDAOTest ...@@ -74,9 +75,13 @@ public final class SampleDAOTest extends AbstractDAOTest
final SamplePE superContainer = createSample(type2, "superContainer", null); final SamplePE superContainer = createSample(type2, "superContainer", null);
well.setContainer(container); well.setContainer(container);
container.setContainer(superContainer); container.setContainer(superContainer);
save(superContainer, container, well); // clear session to avoid using samples from first save(superContainer, container, well);
// level cache
sessionFactory.getCurrentSession().clear(); // clear session to avoid using samples from first level cache
Session currentSession = sessionFactory.getCurrentSession();
currentSession.flush();
currentSession.clear();
final List<SamplePE> samples = listSamplesFromHomeDatabase(type3); final List<SamplePE> samples = listSamplesFromHomeDatabase(type3);
final SamplePE foundWell = findSample(well, samples); final SamplePE foundWell = findSample(well, samples);
assertTrue(HibernateUtils.isInitialized(foundWell.getContainer())); assertTrue(HibernateUtils.isInitialized(foundWell.getContainer()));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment