Skip to content
Snippets Groups Projects
Commit 8bb87dee authored by cramakri's avatar cramakri
Browse files

LMS-2391 Fixed tests.

SVN: 22052
parent df02eda9
No related branches found
No related tags found
No related merge requests found
Showing
with 64 additions and 21 deletions
...@@ -84,4 +84,6 @@ if dataset.getExperiment() is None: ...@@ -84,4 +84,6 @@ if dataset.getExperiment() is None:
exp = retrieve_experiment(tr, exp_id) exp = retrieve_experiment(tr, exp_id)
if exp is not None: if exp is not None:
dataset.setExperiment(exp) dataset.setExperiment(exp)
original_dataset.setExperiment(exp)
tsv_dataset.setExperiment(exp)
...@@ -71,5 +71,7 @@ if dataset.getExperiment() is None: ...@@ -71,5 +71,7 @@ if dataset.getExperiment() is None:
exp = retrieve_experiment(tr, exp_id) exp = retrieve_experiment(tr, exp_id)
if exp is not None: if exp is not None:
dataset.setExperiment(exp) dataset.setExperiment(exp)
original_dataset.setExperiment(exp)
tsv_dataset.setExperiment(exp)
...@@ -72,5 +72,7 @@ if dataset.getExperiment() is None: ...@@ -72,5 +72,7 @@ if dataset.getExperiment() is None:
exp = retrieve_experiment(tr, exp_id) exp = retrieve_experiment(tr, exp_id)
if exp is not None: if exp is not None:
dataset.setExperiment(exp) dataset.setExperiment(exp)
original_dataset.setExperiment(exp)
tsv_dataset.setExperiment(exp)
...@@ -113,5 +113,7 @@ if dataset.getExperiment() is None: ...@@ -113,5 +113,7 @@ if dataset.getExperiment() is None:
exp = retrieve_experiment(tr, exp_id) exp = retrieve_experiment(tr, exp_id)
if exp is not None: if exp is not None:
dataset.setExperiment(exp) dataset.setExperiment(exp)
original_dataset.setExperiment(exp)
tsv_dataset.setExperiment(exp)
...@@ -51,6 +51,11 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends ...@@ -51,6 +51,11 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends
private static final String EXPERIMENT_IDENTIFIER = "/TEST/TEST/TEST"; private static final String EXPERIMENT_IDENTIFIER = "/TEST/TEST/TEST";
protected static final DataSetType TSV_MULTISTRAIN_EXPORT_DATA_SET_TYPE = new DataSetType(
"TSV_MULTISTRAIN_EXPORT");
protected static final DataSetType TSV_DATA_SET_TYPE = new DataSetType("TSV_EXPORT");
/** /**
* *
* *
...@@ -61,7 +66,7 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends ...@@ -61,7 +66,7 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends
} }
protected RecordingMatcher<AtomicEntityOperationDetails> setUpDataSetRegistrationExpectations( protected RecordingMatcher<AtomicEntityOperationDetails> setUpDataSetRegistrationExpectations(
final DataSetType dataSetType) final DataSetType dataSetType, final DataSetType tsvDataSetType)
{ {
ExperimentBuilder builder = new ExperimentBuilder().identifier(EXPERIMENT_IDENTIFIER); ExperimentBuilder builder = new ExperimentBuilder().identifier(EXPERIMENT_IDENTIFIER);
final Experiment experiment = builder.getExperiment(); final Experiment experiment = builder.getExperiment();
...@@ -72,13 +77,39 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends ...@@ -72,13 +77,39 @@ public abstract class AbstractBaSynthecDataSetRegistratorTest extends
{ {
one(openBisService).createDataSetCode(); one(openBisService).createDataSetCode();
will(returnValue(DATA_SET_CODE)); will(returnValue(DATA_SET_CODE));
String excelDataSetCode = DATA_SET_CODE + "-EXCEL";
one(openBisService).createDataSetCode();
will(returnValue(excelDataSetCode));
String tsvDataSetCode = DATA_SET_CODE + "-TSV";
one(openBisService).createDataSetCode();
will(returnValue(tsvDataSetCode));
atLeast(1).of(openBisService).tryToGetExperiment( atLeast(1).of(openBisService).tryToGetExperiment(
new ExperimentIdentifierFactory(experiment.getIdentifier()) new ExperimentIdentifierFactory(experiment.getIdentifier())
.createIdentifier()); .createIdentifier());
will(returnValue(experiment)); will(returnValue(experiment));
one(dataSetValidator).assertValidDataSet(dataSetType, allowing(openBisService).tryToGetExperiment(null);
new File(new File(stagingDirectory, DATA_SET_CODE), "data")); will(returnValue(null));
one(dataSetValidator).assertValidDataSet(dataSetType, null);
one(dataSetValidator).assertValidDataSet(new DataSetType("EXCEL_ORIGINAL"),
new File(new File(stagingDirectory, excelDataSetCode), "xls"));
if (tsvDataSetType == TSV_MULTISTRAIN_EXPORT_DATA_SET_TYPE)
{
one(dataSetValidator).assertValidDataSet(
TSV_MULTISTRAIN_EXPORT_DATA_SET_TYPE,
new File(new File(stagingDirectory, tsvDataSetCode), "tsv-multi"));
} else
{
one(dataSetValidator).assertValidDataSet(TSV_DATA_SET_TYPE,
new File(new File(stagingDirectory, tsvDataSetCode), "tsv"));
}
one(openBisService).performEntityOperations(with(atomicatOperationDetails)); one(openBisService).performEntityOperations(with(atomicatOperationDetails));
will(returnValue(new AtomicEntityOperationResult())); will(returnValue(new AtomicEntityOperationResult()));
} }
......
...@@ -44,15 +44,16 @@ public class OD600DataSetRegistratorTest extends AbstractBaSynthecDataSetRegistr ...@@ -44,15 +44,16 @@ public class OD600DataSetRegistratorTest extends AbstractBaSynthecDataSetRegistr
createHandler(properties, false, true); createHandler(properties, false, true);
createData("OD600-Example.xlsx"); createData("OD600-Example.xlsx");
final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicatOperationDetails = final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicOperationDetails =
setUpDataSetRegistrationExpectations(DATA_SET_TYPE); setUpDataSetRegistrationExpectations(DATA_SET_TYPE,
TSV_MULTISTRAIN_EXPORT_DATA_SET_TYPE);
handler.handle(markerFile); handler.handle(markerFile);
assertEquals(1, atomicatOperationDetails.recordedObject().getDataSetRegistrations().size()); assertEquals(3, atomicOperationDetails.recordedObject().getDataSetRegistrations().size());
NewExternalData dataSet = NewExternalData dataSet =
atomicatOperationDetails.recordedObject().getDataSetRegistrations().get(0); atomicOperationDetails.recordedObject().getDataSetRegistrations().get(0);
assertEquals(DATA_SET_CODE, dataSet.getCode()); assertEquals(DATA_SET_CODE, dataSet.getCode());
assertEquals(DATA_SET_TYPE, dataSet.getDataSetType()); assertEquals(DATA_SET_TYPE, dataSet.getDataSetType());
......
...@@ -44,15 +44,15 @@ public class MetabolomicsDataSetRegistratorTest extends AbstractBaSynthecDataSet ...@@ -44,15 +44,15 @@ public class MetabolomicsDataSetRegistratorTest extends AbstractBaSynthecDataSet
createHandler(properties, false, true); createHandler(properties, false, true);
createData("Proteomics-Example.xlsx"); createData("Proteomics-Example.xlsx");
final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicatOperationDetails = final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicOperationDetails =
setUpDataSetRegistrationExpectations(DATA_SET_TYPE); setUpDataSetRegistrationExpectations(DATA_SET_TYPE, TSV_DATA_SET_TYPE);
handler.handle(markerFile); handler.handle(markerFile);
assertEquals(1, atomicatOperationDetails.recordedObject().getDataSetRegistrations().size()); assertEquals(3, atomicOperationDetails.recordedObject().getDataSetRegistrations().size());
NewExternalData dataSet = NewExternalData dataSet =
atomicatOperationDetails.recordedObject().getDataSetRegistrations().get(0); atomicOperationDetails.recordedObject().getDataSetRegistrations().get(0);
assertEquals(DATA_SET_CODE, dataSet.getCode()); assertEquals(DATA_SET_CODE, dataSet.getCode());
assertEquals(DATA_SET_TYPE, dataSet.getDataSetType()); assertEquals(DATA_SET_TYPE, dataSet.getDataSetType());
......
...@@ -44,15 +44,15 @@ public class ProteomicsDataSetRegistratorTest extends AbstractBaSynthecDataSetRe ...@@ -44,15 +44,15 @@ public class ProteomicsDataSetRegistratorTest extends AbstractBaSynthecDataSetRe
createHandler(properties, false, true); createHandler(properties, false, true);
createData("Metabolomics-Example.xlsx"); createData("Metabolomics-Example.xlsx");
final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicatOperationDetails = final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicOperationDetails =
setUpDataSetRegistrationExpectations(DATA_SET_TYPE); setUpDataSetRegistrationExpectations(DATA_SET_TYPE, TSV_DATA_SET_TYPE);
handler.handle(markerFile); handler.handle(markerFile);
assertEquals(1, atomicatOperationDetails.recordedObject().getDataSetRegistrations().size()); assertEquals(3, atomicOperationDetails.recordedObject().getDataSetRegistrations().size());
NewExternalData dataSet = NewExternalData dataSet =
atomicatOperationDetails.recordedObject().getDataSetRegistrations().get(0); atomicOperationDetails.recordedObject().getDataSetRegistrations().get(0);
assertEquals(DATA_SET_CODE, dataSet.getCode()); assertEquals(DATA_SET_CODE, dataSet.getCode());
assertEquals(DATA_SET_TYPE, dataSet.getDataSetType()); assertEquals(DATA_SET_TYPE, dataSet.getDataSetType());
......
...@@ -46,15 +46,16 @@ public class TranscriptomicsDataSetRegistratorTest extends AbstractBaSynthecData ...@@ -46,15 +46,16 @@ public class TranscriptomicsDataSetRegistratorTest extends AbstractBaSynthecData
createHandler(properties, false, true); createHandler(properties, false, true);
createData("Transcriptomics-Example.xlsx"); createData("Transcriptomics-Example.xlsx");
final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicatOperationDetails = final RecordingMatcher<ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationDetails> atomicOperationDetails =
setUpDataSetRegistrationExpectations(DATA_SET_TYPE); setUpDataSetRegistrationExpectations(DATA_SET_TYPE,
TSV_MULTISTRAIN_EXPORT_DATA_SET_TYPE);
handler.handle(markerFile); handler.handle(markerFile);
assertEquals(1, atomicatOperationDetails.recordedObject().getDataSetRegistrations().size()); assertEquals(3, atomicOperationDetails.recordedObject().getDataSetRegistrations().size());
NewExternalData dataSet = NewExternalData dataSet =
atomicatOperationDetails.recordedObject().getDataSetRegistrations().get(0); atomicOperationDetails.recordedObject().getDataSetRegistrations().get(0);
assertEquals(DATA_SET_CODE, dataSet.getCode()); assertEquals(DATA_SET_CODE, dataSet.getCode());
assertEquals(DATA_SET_TYPE, dataSet.getDataSetType()); assertEquals(DATA_SET_TYPE, dataSet.getDataSetType());
...@@ -67,10 +68,12 @@ public class TranscriptomicsDataSetRegistratorTest extends AbstractBaSynthecData ...@@ -67,10 +68,12 @@ public class TranscriptomicsDataSetRegistratorTest extends AbstractBaSynthecData
assert null != strainProperty; assert null != strainProperty;
assertEquals("MGP253,MGP776", strainProperty.getValue()); assertEquals("MGP253,MGP776", strainProperty.getValue());
String location = dataSet.getLocation(); NewExternalData tsvDataSet =
atomicOperationDetails.recordedObject().getDataSetRegistrations().get(2);
String location = tsvDataSet.getLocation();
File tsvFile = File tsvFile =
new File(new File(workingDirectory, "/1/" + location), new File(new File(workingDirectory, "/1/" + location),
"tsv/Transcriptomics-Example.xlsx.tsv"); "Transcriptomics-Example.xlsx.tsv");
checkTsvContent(tsvFile); checkTsvContent(tsvFile);
context.assertIsSatisfied(); context.assertIsSatisfied();
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment