SSDM-10397 Code cleanup.

openbis/source/java/ch/ethz/sis/openbis/generic/server/asapi/v3/search/translator/OrderTranslator.java

@@ -150,13 +150,12 @@ public class OrderTranslator
             {
                 final String fullPropertyName = sortingCriteriaFieldName.substring(
                         EntityWithPropertiesSortOptions.PROPERTY.length());
-                final boolean internalProperty = TranslatorUtils.isPropertyInternal(fullPropertyName);
                 final String attributeTypesTableAlias = aliases.get(fullPropertyName.toLowerCase())
                         .get(TableNames.DATA_TYPES_TABLE).getMainTableAlias();
 
                 sqlBuilder.append(SP).append(AND).append(SP);
                 TranslatorUtils.appendInternalExternalConstraint(sqlBuilder, args, attributeTypesTableAlias,
-                        internalProperty);
+                        TranslatorUtils.isPropertyInternal(fullPropertyName));
 
                 sqlBuilder.append(SP).append(AND).append(SP).append(attributeTypesTableAlias).append(PERIOD)
                         .append(CODE_COLUMN).append(SP).append(EQ).append(SP).append(QU);

openbis/source/java/ch/ethz/sis/openbis/generic/server/asapi/v3/search/translator/condition/DateFieldSearchConditionTranslator.java

@@ -208,9 +208,8 @@ public class DateFieldSearchConditionTranslator implements IConditionTranslator<
 
         if (fullPropertyName != null)
         {
-            final boolean internalProperty = TranslatorUtils.isPropertyInternal(fullPropertyName);
             TranslatorUtils.appendInternalExternalConstraint(sqlBuilder, args, entityTypesSubTableAlias,
-                    internalProperty);
+                    TranslatorUtils.isPropertyInternal(fullPropertyName));
             sqlBuilder.append(SP).append(AND).append(SP);
             sqlBuilder.append(aliases.get(tableMapper.getAttributeTypesTable()).getSubTableAlias())
                     .append(PERIOD).append(ColumnNames.CODE_COLUMN).append(SP).append(EQ).append(SP).append(QU);