Skip to content
Snippets Groups Projects
Commit 80254c15 authored by buczekp's avatar buczekp
Browse files

minor: TODO cleanup

SVN: 18815
parent 89ef2070
No related branches found
No related tags found
No related merge requests found
Showing
with 16 additions and 18 deletions
......@@ -39,8 +39,8 @@ import ch.systemsx.cisd.common.ssl.SslCertificateHelper;
*
* @author Chandrasekhar Ramakrishnan
*/
// TODO: This code should be refactored and moved into a common location, but it is a bit difficult
// due to dependencies.
// TODO 2010-05-11, CR: This code should be refactored and moved into a common location,
// but it is a bit difficult due to dependencies.
public class DssServiceRpcFactory implements IRpcServiceFactory
{
private static final int SERVER_TIMEOUT_MIN = 5;
......@@ -82,7 +82,7 @@ public class DssServiceRpcFactory implements IRpcServiceFactory
{
return new File(getConfigDirectory(), "keystore");
}
private File getConfigDirectory()
{
String homeDir = System.getProperty("dss.root");
......
......@@ -17,7 +17,7 @@ import org.springframework.web.HttpRequestMethodNotSupportedException;
*
* @author Chandrasekhar Ramakrishnan
*/
// TODO Refactor to make the reference to DataStoreServlet use the HttpInvokerServlet.
// TODO 2010-04-21, Tomasz Pylak: Refactor to make the reference to DataStoreServlet use the HttpInvokerServlet.
public class HttpInvokerServlet extends HttpServlet
{
private static final long serialVersionUID = 1L;
......
......@@ -87,8 +87,8 @@ public class ExternalDataBO extends AbstractExternalDataBusinessObject implement
public ExternalDataPE getExternalData()
{
// TODO This should throw an exception if the external data is null -- will that cause
// problems with clients?
// TODO 2010-04-12, CR: This should throw an exception if the external data is null
// -- will that cause problems with clients?
return externalData;
}
......
......@@ -17,21 +17,19 @@
package ch.systemsx.cisd.openbis.generic.shared.basic.dto;
/**
*
*
* @author Franz-Josef Elmer
*/
public class PersonTableCell implements ISerializableComparable
{
private static final long serialVersionUID = ServiceVersionHolder.VERSION;
private Person person;
public PersonTableCell(Person person)
{
this.person = person;
}
public Person getPerson()
{
return person;
......@@ -39,7 +37,7 @@ public class PersonTableCell implements ISerializableComparable
public int compareTo(ISerializableComparable o)
{
// TODO Auto-generated method stub
// TODO 2010-10-25, felmer: Auto-generated method stub
return 0;
}
......
......@@ -43,7 +43,8 @@ import ch.systemsx.cisd.openbis.generic.shared.dto.ScriptPE;
/**
* @author Piotr Buczek
*/
public class DynamicPropertyEvaluatorTest extends AssertJUnit // TODO extend AbstractDAOTest
// TODO 2010-11-19, Piotr Buczek: extend AbstractDAOTest
public class DynamicPropertyEvaluatorTest extends AssertJUnit
{
@Test
......
......@@ -547,7 +547,6 @@ public class WellContentDialog extends Dialog
container.add(new Text("["));
String geneSymbolsOrNull = tryGetGeneSymbols(material);
// TODO 2010-10-11, Piotr Buczek: change links in normal view mode not to change URL
if (geneSymbolsOrNull != null && StringUtils.isBlank(geneSymbolsOrNull) == false)
{
String[] symbols = geneSymbolsOrNull.split(" ");
......
......@@ -582,8 +582,7 @@ public class WellSearchGrid extends TypedTableGrid<WellContent>
public void setChannelChooser(
SelectionProvider<SimpleComboValue<String>> selectionProvider)
{
// TODO Auto-generated method stub
// TODO 2010-11-09, felmer: Auto-generated method stub
}
};
ChannelWidgetWithListener widgetWithListener =
......
......@@ -102,8 +102,8 @@ public class HCSDatasetLoader implements IHCSDatasetLoader
private static WellImageChannelStack convert(ImgChannelStackDTO stack)
{
return new WellImageChannelStack(stack.getId(), stack.getRow(), stack.getColumn(), stack
.getT(), stack.getZ());
return new WellImageChannelStack(stack.getId(), stack.getRow(), stack.getColumn(),
stack.getT(), stack.getZ());
}
public PlateImageParameters getImageParameters()
......@@ -119,6 +119,7 @@ public class HCSDatasetLoader implements IHCSDatasetLoader
List<String> channelsLabels = new ArrayList<String>();
for (ImgChannelDTO channel : channels)
{
// TODO 2010-11-19, IA: is this escaping needed?
channelsCodes.add(StringEscapeUtils.escapeCsv(channel.getCode()));
channelsLabels.add(StringEscapeUtils.escapeCsv(channel.getLabel()));
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment