minor: - Add final keyword when possible.

- Split String to make formatted text nicer.
- Add javadoc.

SVN: 6326

common/source/java/ch/systemsx/cisd/common/logging/Log4jSimpleLogger.java

@@ -25,13 +25,13 @@ import org.apache.log4j.Priority;
  * 
  * @author Bernd Rinn
  */
-public class Log4jSimpleLogger implements ISimpleLogger
+public final class Log4jSimpleLogger implements ISimpleLogger
 {
     private final Priority log4jOverridePriorityOrNull;
 
     private final Logger log4jLogger;
 
-    static final Level toLog4jPriority(LogLevel level)
+    static final Level toLog4jPriority(final LogLevel level)
     {
         switch (level)
         {
@@ -60,7 +60,7 @@ public class Log4jSimpleLogger implements ISimpleLogger
      *            the one provided to the
      *            {@link ISimpleLogger#log(ch.systemsx.cisd.common.logging.LogLevel, String)}.
      */
-    public Log4jSimpleLogger(Logger log4jLogger, Priority log4jOverridePriorityOrNull)
+    public Log4jSimpleLogger(final Logger log4jLogger, final Priority log4jOverridePriorityOrNull)
     {
         this.log4jOverridePriorityOrNull = log4jOverridePriorityOrNull;
         this.log4jLogger = log4jLogger;
@@ -71,12 +71,12 @@ public class Log4jSimpleLogger implements ISimpleLogger
      * 
      * @param log4jLogger The log4j logger to use.
      */
-    public Log4jSimpleLogger(Logger log4jLogger)
+    public Log4jSimpleLogger(final Logger log4jLogger)
     {
         this(log4jLogger, null);
     }
 
-    public void log(LogLevel level, String message)
+    public final void log(final LogLevel level, final String message)
     {
         if (log4jOverridePriorityOrNull != null)
         {

common/source/java/ch/systemsx/cisd/common/utilities/FileUtilities.java

@@ -878,13 +878,8 @@ public final class FileUtilities
         {
             if (directory.isFile())
             {
-                logger
-                        .log(
-                                LogLevel.ERROR,
-                                String
-                                        .format(
-                                                "Failed to get listing of directory '%s' (path is file instead of directory).",
-                                                directory));
+                logger.log(LogLevel.ERROR, String.format("Failed to get listing of directory '%s' "
+                        + "(path is file instead of directory).", directory));
             } else
             {
                 logger.log(LogLevel.ERROR, String.format(

common/sourceTest/java/ch/systemsx/cisd/common/mail/MailClientTest.java

@@ -27,12 +27,14 @@ import ch.systemsx.cisd.common.utilities.AbstractFileSystemTestCase;
 import ch.systemsx.cisd.common.utilities.FileUtilities;
 
 /**
+ * Test cases for corresponding {@link MailClient} class.
+ * 
  * @author Franz-Josef Elmer
  */
-public class MailClientTest extends AbstractFileSystemTestCase
+public final class MailClientTest extends AbstractFileSystemTestCase
 {
     @Test
-    public void test()
+    public final void test()
     {
         String path = workingDirectory.getPath() + "/emails";
         File emailFolder = new File(path);