SSDM-14261 : Slow user roles filtering

server-application-server/source/java/ch/systemsx/cisd/openbis/generic/server/task/UserManager.java

@@ -1553,6 +1553,41 @@ public class UserManager
             }
             if (roleCreations.isEmpty() == false)
             {
+                // Filter out already existing roles to not repeat creations
+                // This is to manage a corner case when a user role has been added manually unnecessarily.
+                List<RoleAssignmentCreation> filteredRoleCreations = new ArrayList<>();
+                for (RoleAssignmentCreation roleAssignmentCreationToCheck : roleCreations)
+                {
+                    PersonPermId userId = (PersonPermId) roleAssignmentCreationToCheck.getUserId();
+                    SpacePermId spaceId = (SpacePermId) roleAssignmentCreationToCheck.getSpaceId();
+                    RoleAssignmentSearchCriteria roleAssignmentSearchCriteria =
+                            new RoleAssignmentSearchCriteria();
+                    roleAssignmentSearchCriteria.withUser().withUserId()
+                            .thatEquals(userId.getPermId());
+                    roleAssignmentSearchCriteria.withSpace().withCode()
+                            .thatEquals(spaceId.getPermId());
+                    SearchResult<RoleAssignment> roleAssignmentSearchResult =
+                            service.searchRoleAssignments(sessionToken,
+                                    roleAssignmentSearchCriteria, new RoleAssignmentFetchOptions());
+
+                    boolean found = false;
+                    if (!roleAssignmentSearchResult.getObjects().isEmpty())
+                    {
+                        Role role = roleAssignmentCreationToCheck.getRole();
+                        for (RoleAssignment roleAssignment : roleAssignmentSearchResult.getObjects())
+                        {
+                            if (roleAssignment.getRole().equals(role))
+                            {
+                                found = true;
+                            }
+                        }
+                    }
+                    if (!found)
+                    {
+                        filteredRoleCreations.add(roleAssignmentCreationToCheck);
+                    }
+                }
+                roleCreations = filteredRoleCreations;
                 operations.add(new CreateRoleAssignmentsOperation(roleCreations));
             }
             if (roleDeletions.isEmpty() == false)