Skip to content
Snippets Groups Projects
Commit 43d208f3 authored by felmer's avatar felmer
Browse files

LMS-1737 bug fixed

SVN: 17853
parent 46f24c9e
No related branches found
No related tags found
No related merge requests found
...@@ -99,11 +99,11 @@ public class URLMethodWithParameters implements IsSerializable ...@@ -99,11 +99,11 @@ public class URLMethodWithParameters implements IsSerializable
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
if (width > 0) if (width > 0)
{ {
builder.append("width='").append(width).append("' "); builder.append(" width='").append(width).append("'");
} }
if (height > 0) if (height > 0)
{ {
builder.append("height='").append(height).append("' "); builder.append(" height='").append(height).append("'");
} }
return "<div align='center'>" + linkStart + "<img src='" + imageURL + "' alt='" + " image " return "<div align='center'>" + linkStart + "<img src='" + imageURL + "' alt='" + " image "
+ "'" + builder + "/>" + linkEnd + "</div>"; + "'" + builder + "/>" + linkEnd + "</div>";
......
...@@ -151,7 +151,7 @@ public class GeneratedImageTableCell implements ISerializableComparable ...@@ -151,7 +151,7 @@ public class GeneratedImageTableCell implements ISerializableComparable
urlMethodThumb.addParameter(IMAGE_HEIGHT_PARAM, thumbnailHeight); urlMethodThumb.addParameter(IMAGE_HEIGHT_PARAM, thumbnailHeight);
return URLMethodWithParameters.createEmbededImageHtml(urlMethodThumb.toString(), return URLMethodWithParameters.createEmbededImageHtml(urlMethodThumb.toString(),
urlMethodImage.toString(), 0, 0); urlMethodImage.toString(), thumbnailWidth, thumbnailHeight);
} }
} }
...@@ -14,15 +14,15 @@ public class GeneratedImageTableCellTest extends AssertJUnit ...@@ -14,15 +14,15 @@ public class GeneratedImageTableCellTest extends AssertJUnit
@Test @Test
public void testAgainstSimpleImageHTMLRenderer() public void testAgainstSimpleImageHTMLRenderer()
{ {
GeneratedImageTableCell cell = new GeneratedImageTableCell("servletName", 600, 300, 60, 60); GeneratedImageTableCell cell = new GeneratedImageTableCell("servletName", 600, 300, 60, 30);
cell.addParameter("code", "CODE_8472"); cell.addParameter("code", "CODE_8472");
String cellHTML = cell.getHTMLString("http://my.server.ch", "sessionToken"); String cellHTML = cell.getHTMLString("http://my.server.ch", "sessionToken");
String rendererHTML = String rendererHTML =
URLMethodWithParameters URLMethodWithParameters
.createEmbededImageHtml( .createEmbededImageHtml(
"http://my.server.ch/servletName?sessionID=sessionToken&code=CODE_8472&w=60&h=60", "http://my.server.ch/servletName?sessionID=sessionToken&code=CODE_8472&w=60&h=30",
"http://my.server.ch/servletName?sessionID=sessionToken&code=CODE_8472&w=600&h=300", "http://my.server.ch/servletName?sessionID=sessionToken&code=CODE_8472&w=600&h=300",
600, 300); 60, 30);
assertEquals(cellHTML, rendererHTML); assertEquals(cellHTML, rendererHTML);
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment