[LMS-2301] improved error handling and null recipient email (e.g. 'test' user doesn't have email)

SVN: 22050

datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/JythonBasedReportingPlugin.java

@@ -22,7 +22,6 @@ import java.util.Properties;
 
 import org.apache.log4j.Logger;
 
-import ch.systemsx.cisd.common.evaluator.EvaluatorException;
 import ch.systemsx.cisd.common.exceptions.UserFailureException;
 import ch.systemsx.cisd.common.logging.LogCategory;
 import ch.systemsx.cisd.common.logging.LogFactory;
@@ -109,7 +108,7 @@ public class JythonBasedReportingPlugin extends AbstractTableModelReportingPlugi
                 operationLog.info("Reporting done");
                 JythonBasedPluginUtils.closeContent(iDataSets);
             }
-        } catch (EvaluatorException ex)
+        } catch (RuntimeException ex)
         {
             notifyLog.error(ex.getMessage());
             throw new UserFailureException("Chosen plugin failed to create a report.");

datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/MailService.java

@@ -45,16 +45,15 @@ public class MailService implements IMailService
 
     private final String defaultBodyText;
 
-    public MailService(IMailClient mailClient, String recipientAddress)
+    public MailService(IMailClient mailClient, String recipientAddressOrNull)
     {
-        this(mailClient, recipientAddress, DEFAULT_SUBJECT, DEFAULT_BODY_TEXT);
+        this(mailClient, recipientAddressOrNull, DEFAULT_SUBJECT, DEFAULT_BODY_TEXT);
     }
 
-    public MailService(IMailClient mailClient, String recipientAddress, String defaultSubject,
-            String defaultBodyText)
+    public MailService(IMailClient mailClient, String recipientAddressOrNull,
+            String defaultSubject, String defaultBodyText)
     {
-        assert recipientAddress != null;
-        this.senderService = createEmailSenderService(mailClient, recipientAddress);
+        this.senderService = createEmailSenderService(mailClient, recipientAddressOrNull);
         this.defaultSubject = defaultSubject;
         this.defaultBodyText = defaultBodyText;
     }
@@ -65,9 +64,9 @@ public class MailService implements IMailService
     }
 
     static IEmailSenderService createEmailSenderService(final IMailClient mailClient,
-            final String recipientAddress)
+            final String recipientAddressOrNull)
     {
-        final EMailAddress recipient = new EMailAddress(recipientAddress);
+        final EMailAddress recipient = new EMailAddress(recipientAddressOrNull);
         return new IEmailSenderService()
             {