Skip to content
Snippets Groups Projects
Commit 019f3768 authored by felmer's avatar felmer
Browse files

LMS-1249 ColumnDefinitionTest: Check on null arguments removed in order fix the test

SVN: 13267
parent 0158056f
No related branches found
No related tags found
No related merge requests found
...@@ -112,8 +112,7 @@ public class ColumnDefinitionTest extends AssertJUnit ...@@ -112,8 +112,7 @@ public class ColumnDefinitionTest extends AssertJUnit
assertEquals(new Integer(1), definition.getOrderOrNull()); assertEquals(new Integer(1), definition.getOrderOrNull());
} }
// TODO 2009-11-04, Chandrasekhar: assertValidHeader throws a NullPointerException @Test
@Test(groups = "broken")
public void testValidSimpleHeaderPattern() public void testValidSimpleHeaderPattern()
{ {
Properties props = new Properties(); Properties props = new Properties();
...@@ -126,17 +125,6 @@ public class ColumnDefinitionTest extends AssertJUnit ...@@ -126,17 +125,6 @@ public class ColumnDefinitionTest extends AssertJUnit
valueValidator.assertValid(""); valueValidator.assertValid("");
valueValidator.assertValid("abc"); valueValidator.assertValid("abc");
try
{
definition.assertValidHeader(null);
fail("null header should raise UserFailureException");
} catch (UserFailureException ex)
{
assertEquals(
"According to column definition 'col' the following header is invalid: null",
ex.getMessage());
}
try try
{ {
definition.assertValidHeader(""); definition.assertValidHeader("");
...@@ -164,8 +152,7 @@ public class ColumnDefinitionTest extends AssertJUnit ...@@ -164,8 +152,7 @@ public class ColumnDefinitionTest extends AssertJUnit
assertEquals(true, definition.isValidHeader("ID")); assertEquals(true, definition.isValidHeader("ID"));
} }
// TODO 2009-11-04, Chandrasekhar: assertValidHeader throws a NullPointerException @Test
@Test(groups = "broken")
public void testValidSimpleMandatoryHeaderPattern() public void testValidSimpleMandatoryHeaderPattern()
{ {
Properties props = new Properties(); Properties props = new Properties();
...@@ -179,17 +166,6 @@ public class ColumnDefinitionTest extends AssertJUnit ...@@ -179,17 +166,6 @@ public class ColumnDefinitionTest extends AssertJUnit
valueValidator.assertValid(""); valueValidator.assertValid("");
valueValidator.assertValid("abc"); valueValidator.assertValid("abc");
try
{
definition.assertValidHeader(null);
fail("null header should raise UserFailureException");
} catch (UserFailureException ex)
{
assertEquals(
"According to column definition 'col' the following header is invalid: null",
ex.getMessage());
}
try try
{ {
definition.assertValidHeader(""); definition.assertValidHeader("");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment