Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
O
openbis
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
sispub
openbis
Commits
019f3768
Commit
019f3768
authored
15 years ago
by
felmer
Browse files
Options
Downloads
Patches
Plain Diff
LMS-1249 ColumnDefinitionTest: Check on null arguments removed in order fix the test
SVN: 13267
parent
0158056f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/validation/ColumnDefinitionTest.java
+2
-26
2 additions, 26 deletions
...temsx/cisd/etlserver/validation/ColumnDefinitionTest.java
with
2 additions
and
26 deletions
datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/validation/ColumnDefinitionTest.java
+
2
−
26
View file @
019f3768
...
@@ -112,8 +112,7 @@ public class ColumnDefinitionTest extends AssertJUnit
...
@@ -112,8 +112,7 @@ public class ColumnDefinitionTest extends AssertJUnit
assertEquals
(
new
Integer
(
1
),
definition
.
getOrderOrNull
());
assertEquals
(
new
Integer
(
1
),
definition
.
getOrderOrNull
());
}
}
// TODO 2009-11-04, Chandrasekhar: assertValidHeader throws a NullPointerException
@Test
@Test
(
groups
=
"broken"
)
public
void
testValidSimpleHeaderPattern
()
public
void
testValidSimpleHeaderPattern
()
{
{
Properties
props
=
new
Properties
();
Properties
props
=
new
Properties
();
...
@@ -126,17 +125,6 @@ public class ColumnDefinitionTest extends AssertJUnit
...
@@ -126,17 +125,6 @@ public class ColumnDefinitionTest extends AssertJUnit
valueValidator
.
assertValid
(
""
);
valueValidator
.
assertValid
(
""
);
valueValidator
.
assertValid
(
"abc"
);
valueValidator
.
assertValid
(
"abc"
);
try
{
definition
.
assertValidHeader
(
null
);
fail
(
"null header should raise UserFailureException"
);
}
catch
(
UserFailureException
ex
)
{
assertEquals
(
"According to column definition 'col' the following header is invalid: null"
,
ex
.
getMessage
());
}
try
try
{
{
definition
.
assertValidHeader
(
""
);
definition
.
assertValidHeader
(
""
);
...
@@ -164,8 +152,7 @@ public class ColumnDefinitionTest extends AssertJUnit
...
@@ -164,8 +152,7 @@ public class ColumnDefinitionTest extends AssertJUnit
assertEquals
(
true
,
definition
.
isValidHeader
(
"ID"
));
assertEquals
(
true
,
definition
.
isValidHeader
(
"ID"
));
}
}
// TODO 2009-11-04, Chandrasekhar: assertValidHeader throws a NullPointerException
@Test
@Test
(
groups
=
"broken"
)
public
void
testValidSimpleMandatoryHeaderPattern
()
public
void
testValidSimpleMandatoryHeaderPattern
()
{
{
Properties
props
=
new
Properties
();
Properties
props
=
new
Properties
();
...
@@ -179,17 +166,6 @@ public class ColumnDefinitionTest extends AssertJUnit
...
@@ -179,17 +166,6 @@ public class ColumnDefinitionTest extends AssertJUnit
valueValidator
.
assertValid
(
""
);
valueValidator
.
assertValid
(
""
);
valueValidator
.
assertValid
(
"abc"
);
valueValidator
.
assertValid
(
"abc"
);
try
{
definition
.
assertValidHeader
(
null
);
fail
(
"null header should raise UserFailureException"
);
}
catch
(
UserFailureException
ex
)
{
assertEquals
(
"According to column definition 'col' the following header is invalid: null"
,
ex
.
getMessage
());
}
try
try
{
{
definition
.
assertValidHeader
(
""
);
definition
.
assertValidHeader
(
""
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment