Skip to content
Snippets Groups Projects

Mik's review - first script

Merged Ghost User requested to merge review_mik into master
1 unresolved thread

For now only the first script. Second one will follow shortly.

Edited by Ghost User

Merge request reports

Merged by schmittuschmittu 6 years ago (Jan 7, 2019 4:43pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
93 93 - learn regressor for movie scores.
94 94
95 95
96 ## Part 3: accuracy, F1, ROC, ...
  • why ? I thought we came to the conclusion that we explain metrics before overfitting ???

    Edited by schmittu
  • Author Contributor

    I didn't touch that. That was done by you after the meet (in ce6f0a47), which indicates an opposite conclusion. (It also agrees better with my vague memory of the discussion on that subject - no certainty however.)

    Edit: also I have no idea why it pops up here in the merge request, but please do also double check first.

  • Please register or sign in to reply
  • I would prefer that you make notes wich we can discuss before you edit the notebooks. Ok ?

    Edited by schmittu
  • Author Contributor

    Makes perfect sense for larger structural changes, but for mid/minor changes like here the notes => discuss => change cycle would be IMVHO quite counter-productive (would either cause over-discussing details or trigger "why change" reaction at the end). As agreed on Skype, let's just try discuss these changes and adjust the merge instead. I guess we could also make more abundant inline annotations/comments meanwhile to be removed at the end (smth like TODO danger boxes in this version).

  • merged

  • Ghost User unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ghost User changed title from WIP: Mik's review to Mik's review - first script

    changed title from WIP: Mik's review to Mik's review - first script

  • Please register or sign in to reply
    Loading