setting history id when is available on the jupyter notebook and the selected...

setting history id when is available on the jupyter notebook and the selected dataset type, comments

jupyter-openbis-extension/static/uploadDialog.js

@@ -59,13 +59,16 @@ define([
         }
 
         function getOpenBISHistoryId() {
+            // Default empty history id
             var resultDatasetHistoryId = "";
+            // Search for the history id on the metadata, new format, hidden from the user
             if(Jupyter && 
                 Jupyter.notebook && 
                 Jupyter.notebook.metadata && 
                 Jupyter.notebook.metadata.openbisHistoryId) {
                 resultDatasetHistoryId = Jupyter.notebook.metadata.openbisHistoryId;
             }
+            // Search for the history id on the cells, older format
             if (!resultDatasetHistoryId) {
                 var resultDatasetHistoryIdIdx = 0;
                 while(Jupyter.notebook.get_cell(resultDatasetHistoryIdIdx) != null) {
@@ -79,7 +82,7 @@ define([
                     resultDatasetHistoryIdIdx++;
                 }
             }
-            return resultDatasetHistoryId;
+            return resultDatasetHistoryId; // We always return at least the empty one
         }
 
         function getDatasetTypes(env, connection_name, dataset_types, input_fields) {
@@ -129,7 +132,7 @@ define([
                                         var mem = state.uploadDataSetTypes[dts[dataset_types.selectedIndex].code]
                                         if (mem == null) {
                                             mem = {
-                                                "$HISTORY_ID" : getOpenBISHistoryId()
+                                                "$HISTORY_ID" : getOpenBISHistoryId() // History Id should get automatically populated if available
                                             }
                                         }
                                         input_field.value = pa.code in mem ? mem[pa.code] : ""