diff --git a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IJavaMigrationStepExecutor.java b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IJavaMigrationStepExecutor.java index 66925f204d7257ec980981d801882b43ac683d91..4f6df71730d1d455a2f39788350c3bb8ae6b5845 100644 --- a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IJavaMigrationStepExecutor.java +++ b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IJavaMigrationStepExecutor.java @@ -19,11 +19,21 @@ package ch.systemsx.cisd.dbmigration; import ch.systemsx.cisd.common.Script; import ch.systemsx.cisd.common.exceptions.Status; - +/** + * A migration step executor. + * + * @author Christian Ribeaud + */ public interface IJavaMigrationStepExecutor { + /** + * Performs some step after the migration has happened. + */ public Status tryPerformPostMigration(final Script sqlScript); + /** + * Performs some step before the migration has happened. + */ public Status tryPerformPreMigration(final Script sqlScript); } diff --git a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IMigrationStep.java b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IMigrationStep.java index 692c648d2294ff96c7ce1ed18ec9562095018395..a4a727c4abde698a4813c412ad8de1e18007c70c 100644 --- a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IMigrationStep.java +++ b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/IMigrationStep.java @@ -16,7 +16,7 @@ package ch.systemsx.cisd.dbmigration; -import org.springframework.jdbc.core.JdbcTemplate; +import org.springframework.jdbc.core.simple.SimpleJdbcTemplate; import ch.systemsx.cisd.common.exceptions.Status; @@ -44,11 +44,11 @@ public interface IMigrationStep /** * Called before the SQL migration is performed. */ - public Status performPreMigration(JdbcTemplate jdbcTemplate); + public Status performPreMigration(final SimpleJdbcTemplate simpleJdbcTemplate); /** * Called after the SQL migration has been performed. */ - public Status performPostMigration(JdbcTemplate jdbcTemplate); + public Status performPostMigration(final SimpleJdbcTemplate simpleJdbcTemplate); } diff --git a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/JavaMigrationStepExecutor.java b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/JavaMigrationStepExecutor.java index c45e1a2a5e4ef570902cc39e17d82c028bce903b..54841948366268c75aa7e8d200a807b219f9a887 100644 --- a/dbmigration/source/java/ch/systemsx/cisd/dbmigration/JavaMigrationStepExecutor.java +++ b/dbmigration/source/java/ch/systemsx/cisd/dbmigration/JavaMigrationStepExecutor.java @@ -22,7 +22,7 @@ import java.util.List; import javax.sql.DataSource; import org.apache.commons.lang.StringUtils; -import org.springframework.jdbc.core.support.JdbcDaoSupport; +import org.springframework.jdbc.core.simple.SimpleJdbcDaoSupport; import ch.systemsx.cisd.common.Script; import ch.systemsx.cisd.common.exceptions.EnvironmentFailureException; @@ -40,7 +40,8 @@ import ch.systemsx.cisd.common.utilities.ClassUtils; * * @author Izabela Adamczyk */ -public class JavaMigrationStepExecutor extends JdbcDaoSupport implements IJavaMigrationStepExecutor +public class JavaMigrationStepExecutor extends SimpleJdbcDaoSupport implements + IJavaMigrationStepExecutor { private static final String JAVA_MIGRATION_STEP_PREFIX = "--JAVA"; @@ -127,18 +128,23 @@ public class JavaMigrationStepExecutor extends JdbcDaoSupport implements IJavaMi } } + // + // IJavaMigrationStepExecutor + // + /** * Returns null if MigrationStep has not been found and status returned by - * {@link IMigrationStep#performPreMigration(org.springframework.jdbc.core.JdbcTemplate)} + * {@link IMigrationStep#performPreMigration(org.springframework.jdbc.core.simple.SimpleJdbcTemplate)} * otherwise. */ - public Status tryPerformPreMigration(final Script sqlScript) + public final Status tryPerformPreMigration(final Script sqlScript) { final IMigrationStep migrationStep = tryExtractMigrationStep(sqlScript); if (migrationStep != null) { - final Status preMigrationStatus = migrationStep.performPreMigration(getJdbcTemplate()); + final Status preMigrationStatus = + migrationStep.performPreMigration(getSimpleJdbcTemplate()); return preMigrationStatus; } else { @@ -148,16 +154,16 @@ public class JavaMigrationStepExecutor extends JdbcDaoSupport implements IJavaMi /** * Returns null if MigrationStep has not been found and status returned by - * {@link IMigrationStep#performPostMigration(org.springframework.jdbc.core.JdbcTemplate)} + * {@link IMigrationStep#performPostMigration(org.springframework.jdbc.core.simple.SimpleJdbcTemplate)} * otherwise. */ - public Status tryPerformPostMigration(final Script sqlScript) + public final Status tryPerformPostMigration(final Script sqlScript) { final IMigrationStep migrationStep = tryExtractMigrationStep(sqlScript); if (migrationStep != null) { final Status postMigrationStatus = - migrationStep.performPostMigration(getJdbcTemplate()); + migrationStep.performPostMigration(getSimpleJdbcTemplate()); return postMigrationStatus; } else { diff --git a/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom001To002.java b/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom001To002.java index f3d4f6051f3adf0d3e53c52801d71dd3eac4526d..dadcc9f8f41cb7fd26235a56964aba276af57023 100644 --- a/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom001To002.java +++ b/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom001To002.java @@ -16,23 +16,28 @@ package ch.systemsx.cisd.dbmigration; -import org.springframework.jdbc.core.JdbcTemplate; +import org.springframework.jdbc.core.simple.SimpleJdbcTemplate; import ch.systemsx.cisd.common.exceptions.Status; /** + * A <code>IMigrationStep</code> implementation for test. + * * @author Izabela Adamczyk */ public class MigrationStepFrom001To002 implements IMigrationStep { - public Status performPostMigration(final JdbcTemplate jdbcTemplate) - { + // + // IMigrationStep + // + public final Status performPostMigration(final SimpleJdbcTemplate simpleJdbcTemplate) + { return Status.OK; } - public Status performPreMigration(final JdbcTemplate jdbcTemplate) + public final Status performPreMigration(final SimpleJdbcTemplate simpleJdbcTemplate) { return Status.OK; } diff --git a/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom002To003.java b/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom002To003.java index 0bb37c79bef908f6cccefabfaf927dec9e1e2c50..5a182419a6ca496097a1206aefb8f14e6a59cbbe 100644 --- a/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom002To003.java +++ b/dbmigration/sourceTest/java/ch/systemsx/cisd/dbmigration/MigrationStepFrom002To003.java @@ -16,23 +16,28 @@ package ch.systemsx.cisd.dbmigration; -import org.springframework.jdbc.core.JdbcTemplate; +import org.springframework.jdbc.core.simple.SimpleJdbcTemplate; import ch.systemsx.cisd.common.exceptions.Status; /** + * A <code>IMigrationStep</code> implementation for test. + * * @author Izabela Adamczyk */ public class MigrationStepFrom002To003 implements IMigrationStep { - public Status performPostMigration(final JdbcTemplate jdbcTemplate) - { + // + // IMigrationStep + // + public final Status performPostMigration(final SimpleJdbcTemplate simpleJdbcTemplate) + { return Status.createError("bad post"); } - public Status performPreMigration(final JdbcTemplate jdbcTemplate) + public final Status performPreMigration(final SimpleJdbcTemplate simpleJdbcTemplate) { return Status.createError("bad pre"); }