From e9613ca79cc301827becd8d5ac9a495bdd198e8e Mon Sep 17 00:00:00 2001
From: buczekp <buczekp>
Date: Fri, 10 Jun 2011 13:50:19 +0000
Subject: [PATCH] [LMS-2313] minor: code clarity improvement
SVN: 21671
---
.../application/menu/dataset/DataSetMenu.java | 8 ++---
.../ui/data/AbstractExternalDataGrid.java | 2 +-
.../data/DataSetUploadConfirmationDialog.java | 2 +-
.../ui/data/DataSetUploadForm.java | 2 +-
.../web/client/dto/ApplicationInfo.java | 4 +--
.../web/server/AbstractClientService.java | 6 ++--
...AbstractGenericSampleRegisterEditForm.java | 31 ++++++++++---------
7 files changed, 28 insertions(+), 27 deletions(-)
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/menu/dataset/DataSetMenu.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/menu/dataset/DataSetMenu.java
index 416b3e5da40..03639f58106 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/menu/dataset/DataSetMenu.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/menu/dataset/DataSetMenu.java
@@ -32,6 +32,7 @@ import ch.systemsx.cisd.openbis.generic.client.web.client.application.menu.Actio
import ch.systemsx.cisd.openbis.generic.client.web.client.application.menu.TopMenu;
import ch.systemsx.cisd.openbis.generic.client.web.client.application.menu.TopMenuItem;
import ch.systemsx.cisd.openbis.generic.client.web.client.application.util.IMessageProvider;
+import ch.systemsx.cisd.openbis.generic.client.web.client.dto.ApplicationInfo;
import ch.systemsx.cisd.openbis.generic.shared.basic.BasicConstant;
import ch.systemsx.cisd.openbis.generic.shared.basic.URLMethodWithParameters;
@@ -56,11 +57,10 @@ public class DataSetMenu extends TopMenuItem
componentProvider.getDataSetTypeBrowser()));
submenu.add(new ActionMenu(TopMenu.ActionMenuKind.DATA_SET_MENU_MASS_UPDATE,
messageProvider, componentProvider.getDataSetBatchUpdate()));
+ ApplicationInfo applicationInfo = viewContext.getModel().getApplicationInfo();
boolean cifexConfigured =
- StringUtils
- .isBlank(viewContext.getModel().getApplicationInfo().getCifexRecipient()) == false
- && StringUtils.isBlank(viewContext.getModel().getApplicationInfo()
- .getCIFEXURL()) == false;
+ StringUtils.isNotBlank(applicationInfo.getCifexRecipient())
+ && StringUtils.isNotBlank(applicationInfo.getCifexURL());
if (cifexConfigured)
{
submenu.add(new ActionMenu(TopMenu.ActionMenuKind.DATA_SET_MENU_UPLOAD,
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/AbstractExternalDataGrid.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/AbstractExternalDataGrid.java
index b3f9b33c3bb..a8142e59539 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/AbstractExternalDataGrid.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/AbstractExternalDataGrid.java
@@ -182,7 +182,7 @@ public abstract class AbstractExternalDataGrid
viewContext);
}
});
- if (StringUtils.isBlank(viewContext.getModel().getApplicationInfo().getCIFEXURL()))
+ if (StringUtils.isBlank(viewContext.getModel().getApplicationInfo().getCifexURL()))
{
uploadButton.disable();
}
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadConfirmationDialog.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadConfirmationDialog.java
index 17048784d6c..15a45fd1514 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadConfirmationDialog.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadConfirmationDialog.java
@@ -75,7 +75,7 @@ final class DataSetUploadConfirmationDialog extends
this.viewContext = viewContext;
this.displayedItemsCount = displayedItemsCount;
this.selectedAndDisplayedItemsAction = selectedAndDisplayedItemsAction;
- cifexURL = viewContext.getModel().getApplicationInfo().getCIFEXURL();
+ cifexURL = viewContext.getModel().getApplicationInfo().getCifexURL();
setWidth(LABEL_WIDTH_IN_UPLOAD_DIALOG + FIELD_WIDTH_IN_UPLOAD_DIALOG + 50);
}
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadForm.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadForm.java
index deafc12cb38..079430d7117 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadForm.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/data/DataSetUploadForm.java
@@ -97,7 +97,7 @@ public class DataSetUploadForm extends AbstractRegistrationForm
String sampleIdentifierOrNull)
{
super(viewContext, createSimpleId(sampleIdentifierOrNull));
- cifexURL = viewContext.getModel().getApplicationInfo().getCIFEXURL();
+ cifexURL = viewContext.getModel().getApplicationInfo().getCifexURL();
cifexRecipient = viewContext.getModel().getApplicationInfo().getCifexRecipient();
saveButton.setText(viewContext.getMessage(Dict.BUTTON_UPLOAD_DATA_VIA_CIFEX));
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/dto/ApplicationInfo.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/dto/ApplicationInfo.java
index 21084d23366..d18110e3234 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/dto/ApplicationInfo.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/dto/ApplicationInfo.java
@@ -74,12 +74,12 @@ public final class ApplicationInfo implements IsSerializable
this.version = version;
}
- public void setCIFEXURL(String cifexURL)
+ public void setCifexURL(String cifexURL)
{
this.cifexURL = cifexURL;
}
- public final String getCIFEXURL()
+ public final String getCifexURL()
{
return cifexURL;
}
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/AbstractClientService.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/AbstractClientService.java
index 83c4bbd8a6f..72939c570b6 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/AbstractClientService.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/AbstractClientService.java
@@ -427,7 +427,7 @@ public abstract class AbstractClientService implements IClientService,
if (commonClientService == null || commonClientService == this
|| getApplicationInfoInvocationCount > 0)
{
- applicationInfo.setCIFEXURL(cifexURL);
+ applicationInfo.setCifexURL(cifexURL);
applicationInfo.setCifexRecipient(cifexRecipient);
applicationInfo.setMaxResults(maxResults);
applicationInfo.setWebClientConfiguration(getWebClientConfiguration());
@@ -436,9 +436,9 @@ public abstract class AbstractClientService implements IClientService,
getApplicationInfoInvocationCount++;
ApplicationInfo commonApplicationInfo = commonClientService.getApplicationInfo();
getApplicationInfoInvocationCount--;
- applicationInfo.setCIFEXURL(commonApplicationInfo.getCIFEXURL());
- applicationInfo.setMaxResults(commonApplicationInfo.getMaxResults());
+ applicationInfo.setCifexURL(commonApplicationInfo.getCifexURL());
applicationInfo.setCifexRecipient(commonApplicationInfo.getCifexRecipient());
+ applicationInfo.setMaxResults(commonApplicationInfo.getMaxResults());
applicationInfo.setWebClientConfiguration(commonApplicationInfo
.getWebClientConfiguration());
}
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/plugin/generic/client/web/client/application/sample/AbstractGenericSampleRegisterEditForm.java b/openbis/source/java/ch/systemsx/cisd/openbis/plugin/generic/client/web/client/application/sample/AbstractGenericSampleRegisterEditForm.java
index 5b40674ad19..78daa354a59 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/plugin/generic/client/web/client/application/sample/AbstractGenericSampleRegisterEditForm.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/plugin/generic/client/web/client/application/sample/AbstractGenericSampleRegisterEditForm.java
@@ -51,6 +51,7 @@ import ch.systemsx.cisd.openbis.generic.client.web.client.application.ui.field.S
import ch.systemsx.cisd.openbis.generic.client.web.client.application.ui.file.AttachmentsFileFieldManager;
import ch.systemsx.cisd.openbis.generic.client.web.client.application.ui.widget.FieldUtil;
import ch.systemsx.cisd.openbis.generic.client.web.client.application.util.IDelegatedAction;
+import ch.systemsx.cisd.openbis.generic.client.web.client.dto.ApplicationInfo;
import ch.systemsx.cisd.openbis.generic.client.web.client.dto.ExperimentIdentifier;
import ch.systemsx.cisd.openbis.generic.shared.basic.IIdAndCodeHolder;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.EntityKind;
@@ -121,11 +122,10 @@ abstract public class AbstractGenericSampleRegisterEditForm extends
addUploadFeatures(sesionKeys);
extractInitialValues(actionContext);
saveUploadButton = createSaveAndUploadButton();
+ ApplicationInfo applicationInfo = viewContext.getModel().getApplicationInfo();
boolean cifexConfigured =
- StringUtils
- .isBlank(viewContext.getModel().getApplicationInfo().getCifexRecipient()) == false
- && StringUtils.isBlank(viewContext.getModel().getApplicationInfo()
- .getCIFEXURL()) == false;
+ StringUtils.isNotBlank(applicationInfo.getCifexRecipient())
+ && StringUtils.isNotBlank(applicationInfo.getCifexURL());
if (cifexConfigured)
{
formPanel.addButton(saveUploadButton);
@@ -301,17 +301,18 @@ abstract public class AbstractGenericSampleRegisterEditForm extends
.withSuffix(getSampleTypeCode()));
parentsArea = new ParentSamplesArea(viewContext, getId());
SampleChooserButton parentChooserButton = parentButton.getChooserButton();
- parentChooserButton.addChosenEntityListener(new IChosenEntityListener<TableModelRowWithObject<Sample>>()
- {
- public void entityChosen(TableModelRowWithObject<Sample> entity)
- {
- if (entity != null)
+ parentChooserButton
+ .addChosenEntityListener(new IChosenEntityListener<TableModelRowWithObject<Sample>>()
{
- String sampleIdentifier = entity.getObjectOrNull().getIdentifier();
- parentsArea.appendItem(sampleIdentifier);
- }
- }
- });
+ public void entityChosen(TableModelRowWithObject<Sample> entity)
+ {
+ if (entity != null)
+ {
+ String sampleIdentifier = entity.getObjectOrNull().getIdentifier();
+ parentsArea.appendItem(sampleIdentifier);
+ }
+ }
+ });
container =
SampleChooserField.create(viewContext.getMessage(Dict.PART_OF_SAMPLE), false, null,
true, false, false, viewContext.getCommonViewContext(), getId()
@@ -358,7 +359,7 @@ abstract public class AbstractGenericSampleRegisterEditForm extends
builder.append(code);
return builder.toString().toUpperCase();
}
-
+
/** sets visibility of container and parent fields dependent on sample type */
private final void setContainerAndParentVisibility(final SampleType sampleType)
{
--
GitLab