diff --git a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/etl/DatasetMappingResolver.java b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/etl/DatasetMappingResolver.java index 9646ff5254820d5d1b84b08f5bd8593b2073098e..6f4d799b83e2c6385dc9b635f201eea20f83d210 100644 --- a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/etl/DatasetMappingResolver.java +++ b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/etl/DatasetMappingResolver.java @@ -229,23 +229,18 @@ class DatasetMappingResolver return false; } - boolean conversionRequired = isConversionRequired(mapping); - if (conversion == MLConversionType.NONE && conversionRequired) - { - log.datasetMappingError(mapping, "conversion column cannot be empty " - + "for this type of file."); - return false; - } - if (conversion != MLConversionType.NONE && conversionRequired == false) + boolean conversionAllowed = isConversionAllowed(mapping); + if (conversion != MLConversionType.NONE && conversionAllowed == false) { log.datasetMappingError(mapping, "conversion column must be empty " + "for this type of file."); return false; + } return true; } - private static boolean isConversionRequired(final DataSetMappingInformation dataset) + private static boolean isConversionAllowed(final DataSetMappingInformation dataset) { String extension = FilenameUtils.getExtension(dataset.getFileName()); boolean conversionRequired = extension.equalsIgnoreCase(ConstantsYeastX.MZXML_EXT);