diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/plugins/DataSetHierarchyHelper.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/plugins/DataSetHierarchyHelper.java index ecf4150370f4019640fb383a71e79e402c61d293..f1ff389199d5f5a3d20de3c7dca04bac9e1cedf6 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/plugins/DataSetHierarchyHelper.java +++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/plugins/DataSetHierarchyHelper.java @@ -31,6 +31,8 @@ import ch.systemsx.cisd.openbis.generic.shared.dto.SimpleDataSetInformationDTO; public class DataSetHierarchyHelper { + private static String NOT_DIRECTLY_CONNECTED = "NOT_DIRECTLY_CONNECTED"; + /** * For given {@link SimpleDataSetInformationDTO} creates relevant path part. * @@ -190,7 +192,12 @@ public class DataSetHierarchyHelper private static String sample(SimpleDataSetInformationDTO data) { - return merge(PathElementKey.Sample, data.getSampleCode()); + String pathElementValue = data.getSampleCode(); + if (pathElementValue == null) + { + pathElementValue = NOT_DIRECTLY_CONNECTED; + } + return merge(PathElementKey.Sample, pathElementValue); } private static String project(SimpleDataSetInformationDTO data) diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/UploadingCommand.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/UploadingCommand.java index bc69d9ef540d69200317d6597aa7b4370d063629..c33aa722cb7cce76ce5b07cf154c321db3ce472b 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/UploadingCommand.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/UploadingCommand.java @@ -455,7 +455,8 @@ class UploadingCommand implements IDataSetCommand String smtpUser = mailClientParameters.getSmtpUser(); String smtpPassword = mailClientParameters.getSmtpPassword(); IMailClient mailClient = new MailClient(from, smtpHost, smtpUser, smtpPassword); - mailClient.sendMessage("[Data Set Server] Uploading failed", message, null, null, userEMail); + mailClient + .sendMessage("[Data Set Server] Uploading failed", message, null, null, userEMail); } public String getDescription() diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/dto/DataSetInformation.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/dto/DataSetInformation.java index 6ec856646fbac9c0621b3969349b4fb2f8603112..ef3ba501666c70102d17610d0b22c7dd500a0f34 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/dto/DataSetInformation.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/dto/DataSetInformation.java @@ -202,6 +202,8 @@ public class DataSetInformation implements Serializable sampleCode); } + /** @deprecated may be null */ + @Deprecated public final String getSampleCode() { return sampleCode;