diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/AbstractWebStartClientServingServlet.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/AbstractWebStartClientServingServlet.java index a20e94db789fc2c8a6e6f0e4df46a45ac963dac8..b654c58ecb4713708f69b1d69b71c5a61585cbbc 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/AbstractWebStartClientServingServlet.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/AbstractWebStartClientServingServlet.java @@ -42,8 +42,6 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.BasicConstant; */ public abstract class AbstractWebStartClientServingServlet extends AbstractServlet { - private static final long serialVersionUID = 1L; - private static final String SERVER_URL = BasicConstant.SERVER_URL_PARAMETER; private static final String CODEBASE_URL = BasicConstant.CODEBASE_PARAMETER; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/DataSetUploadClientServingServlet.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/DataSetUploadClientServingServlet.java index 2747d1856af85917f0592e552d38e1eb2f46dfbb..121f501cf7fe227f52495ae17a55b95d519d5284 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/DataSetUploadClientServingServlet.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/api/gui/DataSetUploadClientServingServlet.java @@ -34,8 +34,6 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.BasicConstant; "/openbis/openbis/" + BasicConstant.DATA_SET_UPLOAD_CLIENT_PATH }) public class DataSetUploadClientServingServlet extends AbstractWebStartClientServingServlet { - private static final long serialVersionUID = 1L; - private static final Template JNLP_TEMPLATE = new Template( "<?xml version='1.0' encoding='utf-8'?>\n" + "<jnlp spec='1.0+' codebase='${base-URL}'>\n" + " <information>\n" diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/model/EntityGridModelFactory.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/model/EntityGridModelFactory.java index 91a2a787dc16fdc0937096efbb7ca79acda9d6c8..3469ffc84a5c4648302af276afe5257a4b51eab7 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/model/EntityGridModelFactory.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/model/EntityGridModelFactory.java @@ -52,8 +52,6 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.dto.RealNumberFormatingPara */ public class EntityGridModelFactory<T extends IEntityPropertiesHolder> { - private static final long serialVersionUID = 1L; - private final IViewContext<?> viewContext; private final IColumnDefinitionKind<T>[] staticColumnDefinitions; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnListener.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnListener.java index 1ea8ccd1ebc8fef372e77590f5c00e188fecca7e..55978cfd72a66b72601d1346d4188467b4a0082c 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnListener.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnListener.java @@ -65,7 +65,7 @@ public final class ColumnListener<T, M extends BaseEntityModel<T>> implements * This method does nothing if no cell listener has been registered for column determined by the * event. */ - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) public void handleEvent(GridEvent be) { ICellListener<T> listener = getCellListener(be); diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/widget/SimpleModelComboBox.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/widget/SimpleModelComboBox.java index 7fc5c825bcb26825eee2438bf669f142b7849756..ea011d1157c861dec8a19f9062221c286b763df4 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/widget/SimpleModelComboBox.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/widget/SimpleModelComboBox.java @@ -81,11 +81,9 @@ public class SimpleModelComboBox<T> extends SimpleComboBox<LabeledItem<T>> private void setModel(List<LabeledItem<T>> modelItems) { - int i = 0; for (LabeledItem<T> item : modelItems) { add(item); - i++; } } diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/util/lang/Entities.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/util/lang/Entities.java index 50c0180caa42889ab528a55d98a037dc475cab27..655cc6fd17df1ccc93392d65a20a41f47da1ea2f 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/util/lang/Entities.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/util/lang/Entities.java @@ -37,7 +37,6 @@ import java.util.TreeMap; * * @author Piotr Buczek */ -@SuppressWarnings("unchecked") class Entities { @@ -458,7 +457,7 @@ class Entities static class PrimitiveEntityMap implements EntityMap { - private Map mapNameToValue = new HashMap(); + private Map<String, Integer> mapNameToValue = new HashMap<String, Integer>(); private IntHashMap mapValueToName = new IntHashMap(); @@ -495,9 +494,9 @@ class Entities static abstract class MapIntMap implements Entities.EntityMap { - protected Map mapNameToValue; + protected Map<String, Integer> mapNameToValue; - protected Map mapValueToName; + protected Map<Integer, String> mapValueToName; /** * {@inheritDoc} @@ -513,7 +512,7 @@ class Entities */ public String name(int value) { - return (String) mapValueToName.get(new Integer(value)); + return mapValueToName.get(new Integer(value)); } /** @@ -537,8 +536,8 @@ class Entities */ public HashEntityMap() { - mapNameToValue = new HashMap(); - mapValueToName = new HashMap(); + mapNameToValue = new HashMap<String, Integer>(); + mapValueToName = new HashMap<Integer, String>(); } } @@ -549,8 +548,8 @@ class Entities */ public TreeEntityMap() { - mapNameToValue = new TreeMap(); - mapValueToName = new TreeMap(); + mapNameToValue = new TreeMap<String, Integer>(); + mapValueToName = new TreeMap<Integer, String>(); } } diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/UploadServiceServlet.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/UploadServiceServlet.java index 6b7b995c11f7715f2292a8ba68d54b1a17c162d1..017d7905bfb6a4ae6caf506865a8d109caaf01f7 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/UploadServiceServlet.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/UploadServiceServlet.java @@ -67,8 +67,8 @@ import ch.systemsx.cisd.common.utilities.Message; { "/upload", "/openbis/upload" }) public final class UploadServiceServlet extends AbstractCommandController { - private static final Logger operationLog = - LogFactory.getLogger(LogCategory.OPERATION, UploadServiceServlet.class); + private static final Logger operationLog = LogFactory.getLogger(LogCategory.OPERATION, + UploadServiceServlet.class); ISessionFilesSetter sessionFilesSetter; @@ -86,7 +86,7 @@ public final class UploadServiceServlet extends AbstractCommandController this(new SessionFilesSetter()); } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) private final static Iterator<String> cast(final Iterator iterator) { return iterator; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/CacheManager.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/CacheManager.java index 9cdc013eddc19cb91978c863740e78b39cd02a53..a0ea9f43f31d046e04960062f603f43a9508ad71 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/CacheManager.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/CacheManager.java @@ -32,8 +32,6 @@ import ch.systemsx.cisd.common.utilities.TokenGenerator; */ public class CacheManager<K, T> { - private static final long serialVersionUID = 1L; - private final IResultSetKeyGenerator<K> keyProvider; private static final Logger operationLog = diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ColumnSortUtils.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ColumnSortUtils.java index fc6a9a08b508fa13aee982e57e632df0f99cf7d6..9df9709db6d43bda22cd76e492592b7fd7aa3d5f 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ColumnSortUtils.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ColumnSortUtils.java @@ -60,6 +60,7 @@ class ColumnSortUtils return new Comparator<GridRowModel<T>>() { + @SuppressWarnings("rawtypes") public int compare(GridRowModel<T> o1, GridRowModel<T> o2) { Comparable v1 = sortField.tryGetComparableValue(o1); diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/AuthenticationServiceHolder.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/AuthenticationServiceHolder.java index dafef7762c2c2c59bd72870bc97c009d89e3bad3..461900109f62b58289329078a7af02b4f517a697 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/AuthenticationServiceHolder.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/AuthenticationServiceHolder.java @@ -48,7 +48,7 @@ public final class AuthenticationServiceHolder implements FactoryBean return authenticationService; } - @SuppressWarnings("unchecked") + @SuppressWarnings("rawtypes") public final Class getObjectType() { return IAuthenticationService.class; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationAdvisor.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationAdvisor.java index 7b7fd488170c96296fd3ec19797430fda767ce25..5b3850dd8164494647796b3c0b7a047917d810eb 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationAdvisor.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationAdvisor.java @@ -120,7 +120,7 @@ public final class AuthorizationAdvisor extends DefaultPointcutAdvisor } } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) private final static Argument<?> toArgument(final Parameter<AuthorizationGuard> parameter, final Object[] args) { diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationDataProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationDataProvider.java index 207171f46529bcd590be5fc6b8bcbf67b10f6550..c003c1afa979e6b6eb5fa413738f19c736d3a769 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationDataProvider.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationDataProvider.java @@ -392,7 +392,7 @@ final public class AuthorizationDataProvider implements IAuthorizationDataProvid * methods. * </p> */ - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) private static final <T> List<T> cast(final List list) { return list; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/AbstractDAO.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/AbstractDAO.java index cd4cbe260878ef25e15eec15bca6fac659d36249..ab851b519f26e285b634603798a4e4ccb3bd2f3e 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/AbstractDAO.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/AbstractDAO.java @@ -90,7 +90,7 @@ public abstract class AbstractDAO extends HibernateDaoSupport /** * Validates given <i>Persistence Entity</i> using an appropriate {@link ClassValidator}. */ - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) protected final static <E> void validatePE(final E pe) throws DataIntegrityViolationException { ClassValidator<E> validator = (ClassValidator<E>) validators.get(pe.getClass()); @@ -148,7 +148,7 @@ public abstract class AbstractDAO extends HibernateDaoSupport * </p> */ @SuppressWarnings("unchecked") - protected static final <T> List<T> cast(final List list) + protected static final <T> List<T> cast(@SuppressWarnings("rawtypes") final List list) { return list; } diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/util/HibernateTransformer.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/util/HibernateTransformer.java index 615aae5edd566e97682d088a61895e8f4d48e685..12ed3b03c9254814097cd95c27877ae9ef246e04 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/util/HibernateTransformer.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/util/HibernateTransformer.java @@ -137,7 +137,7 @@ public final class HibernateTransformer implements MethodInterceptor // Hibernate3CollectionReplicator // - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) @Override public final <V, T> T replicateCollection(final Collection<V> from, final Class<T> toClass) { diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/PrimitiveValue.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/PrimitiveValue.java index e6fb997ba1af7f59bdfe45839329227d7f8512de..dbd07be81e4a5fcf342ca199626fd9162e52f203 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/PrimitiveValue.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/PrimitiveValue.java @@ -87,7 +87,7 @@ public class PrimitiveValue implements IsSerializable, Serializable, Comparable< } } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) public int compareTo(PrimitiveValue o) { Integer thisTypeOrdinal = getComparableDataTypeOrdinal(); diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/client/testframework/PropertyCheckingManager.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/client/testframework/PropertyCheckingManager.java index 768ed50277f4cf95f866a3ec835968623c6393c1..5296f7b2ec79f533ef6bbd8d8fc963bf1256be72 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/client/testframework/PropertyCheckingManager.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/client/testframework/PropertyCheckingManager.java @@ -55,10 +55,10 @@ public class PropertyCheckingManager extends Assert assertProperties(((PropertyGrid) widget).getProperties()); } - @SuppressWarnings("unchecked") /** * Checks the assertion for the specified properties. */ + @SuppressWarnings({ "unchecked", "rawtypes" }) public void assertProperties(final Map<String, ?> actualProperties) { for (final Map.Entry<String, IValueAssertion> expectedProperty : expectedProperties diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationTestUtil.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationTestUtil.java index e2c67fc7022679860247ea1b4cfc45aadcc22859..ec8f0137fd893ea686e457e75aa740c957f74e84 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationTestUtil.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/AuthorizationTestUtil.java @@ -136,7 +136,7 @@ public final class AuthorizationTestUtil // AbstractAutoProxyCreator // - @SuppressWarnings("unchecked") + @SuppressWarnings("rawtypes") @Override protected final Object[] getAdvicesAndAdvisorsForBean(final Class beanClass, final String beanName, final TargetSource customTargetSource) diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultReturnValueFilterTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultReturnValueFilterTest.java index e26e85754d8d0a9aa4280e791dd99dfe2d004ee8..a62fb1c1040850e4747358fb009d8527ab130daf 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultReturnValueFilterTest.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultReturnValueFilterTest.java @@ -150,7 +150,7 @@ public final class DefaultReturnValueFilterTest assertNull(proceeded); } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) @Test public final void testProceedWithList() {