From c7c446e501d0f83d6e8cbd7911cfee7d250f809b Mon Sep 17 00:00:00 2001
From: brinn <brinn>
Date: Wed, 10 Oct 2012 18:18:55 +0000
Subject: [PATCH] Move timing-related constants from Constants to
TimingParameters and move TimingParameters to sub-package time.
SVN: 27140
---
.../ch/systemsx/cisd/common/Constants.java | 58 ----------------
.../common/concurrent/MonitoringProxy.java | 2 +-
.../common/filesystem/FastHardLinkMaker.java | 2 +-
.../FastRecursiveHardLinkMaker.java | 2 +-
.../common/filesystem/FileOperations.java | 2 +-
.../cisd/common/filesystem/HardLinkMaker.java | 2 +-
.../NonHangingFreeSpaceProvider.java | 4 +-
.../QueueingPathRemoverService.java | 2 +-
.../highwatermark/HighwaterMarkWatcher.java | 4 +-
.../RsyncBasedRecursiveHardLinkMaker.java | 2 +-
.../filesystem/rsync/RsyncVersionChecker.java | 4 +-
.../cisd/common/process/CallableExecutor.java | 4 +-
.../common/{ => time}/TimingParameters.java | 66 ++++++++++++++-----
.../cisd/common/TimingParametersTest.java | 14 ++--
.../concurrent/MonitoringProxyTest.java | 2 +-
.../common/filesystem/FileOperationsTest.java | 2 +-
.../common/reflection/ClassUtilsTest.java | 2 +-
.../filesystem/RetryingPathRemover.java | 4 +-
.../filesystem/intf/AbstractFileStore.java | 4 +-
.../filesystem/remote/RemotePathMover.java | 4 +-
.../store/FileStoreRemoteMounted.java | 2 +-
.../store/RemoteFreeSpaceProvider.java | 4 +-
.../ch/systemsx/cisd/etlserver/ETLDaemon.java | 2 +-
.../cisd/etlserver/FileBasedFileFactory.java | 2 +-
.../systemsx/cisd/etlserver/Parameters.java | 2 +-
.../QueueingDataSetStatusUpdaterService.java | 2 +-
.../cisd/etlserver/FileBasedFileTest.java | 2 +-
.../bsse/cisd/dsu/dss/FlowLaneFeeder.java | 2 +-
.../business/DataStoreServiceFactory.java | 2 +-
29 files changed, 90 insertions(+), 116 deletions(-)
delete mode 100644 common/source/java/ch/systemsx/cisd/common/Constants.java
rename common/source/java/ch/systemsx/cisd/common/{ => time}/TimingParameters.java (77%)
diff --git a/common/source/java/ch/systemsx/cisd/common/Constants.java b/common/source/java/ch/systemsx/cisd/common/Constants.java
deleted file mode 100644
index 1d053c6f7c8..00000000000
--- a/common/source/java/ch/systemsx/cisd/common/Constants.java
+++ /dev/null
@@ -1,58 +0,0 @@
-/*
- * Copyright 2007 ETH Zuerich, CISD
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package ch.systemsx.cisd.common;
-
-
-import org.apache.commons.lang.time.DateUtils;
-
-
-
-/**
- * Constants common to more than one CISD project.
- *
- * @author Bernd Rinn
- */
-public final class Constants
-{
-
- private Constants()
- {
- // This class can not be instantiated.
- }
-
- //
- // Timing
- //
-
- /** Time in seconds to wait before a timeout occurs. */
- public static final int TIMEOUT_SECONDS = 60;
-
- /** Time in milli-seconds to wait before a timeout occurs.. */
- public static final long MILLIS_TO_WAIT_BEFORE_TIMEOUT =
- TIMEOUT_SECONDS * DateUtils.MILLIS_PER_SECOND;
-
- /** Time interval in seconds to wait after an operation failed before retrying it. */
- public static final int INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS = 10;
-
- /** Time interval in milli-seconds to wait after an operation failed before retrying it. */
- public static final long MILLIS_TO_SLEEP_BEFORE_RETRYING =
- INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS * DateUtils.MILLIS_PER_SECOND;
-
- /** Maximal number of retries when an operation fails. */
- public static final int MAXIMUM_RETRY_COUNT = 11;
-
-}
diff --git a/common/source/java/ch/systemsx/cisd/common/concurrent/MonitoringProxy.java b/common/source/java/ch/systemsx/cisd/common/concurrent/MonitoringProxy.java
index 9f5800482bc..550acd6a435 100644
--- a/common/source/java/ch/systemsx/cisd/common/concurrent/MonitoringProxy.java
+++ b/common/source/java/ch/systemsx/cisd/common/concurrent/MonitoringProxy.java
@@ -37,10 +37,10 @@ import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
import ch.systemsx.cisd.base.exceptions.TimeoutExceptionUnchecked;
import ch.systemsx.cisd.base.namedthread.NamedCallable;
import ch.systemsx.cisd.base.namedthread.NamingThreadPoolExecutor;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities.ILogSettings;
import ch.systemsx.cisd.common.logging.ISimpleLogger;
import ch.systemsx.cisd.common.logging.LogLevel;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A class that can provide a dynamic {@link Proxy} for an interface that delegates the method
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/FastHardLinkMaker.java b/common/source/java/ch/systemsx/cisd/common/filesystem/FastHardLinkMaker.java
index 1b56ec7f605..f16c85ca450 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/FastHardLinkMaker.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/FastHardLinkMaker.java
@@ -23,9 +23,9 @@ import org.apache.commons.io.FileCopyUtils;
import ch.systemsx.cisd.base.exceptions.IOExceptionUnchecked;
import ch.systemsx.cisd.base.unix.Unix;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy;
import ch.systemsx.cisd.common.exception.Status;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A {@link IFileImmutableCopier} that uses a native method to create hard links.
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/FastRecursiveHardLinkMaker.java b/common/source/java/ch/systemsx/cisd/common/filesystem/FastRecursiveHardLinkMaker.java
index d3faddfb8d6..359d25c27ff 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/FastRecursiveHardLinkMaker.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/FastRecursiveHardLinkMaker.java
@@ -22,12 +22,12 @@ import org.apache.log4j.Logger;
import ch.systemsx.cisd.base.exceptions.IOExceptionUnchecked;
import ch.systemsx.cisd.base.utilities.OSUtilities;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.Status;
import ch.systemsx.cisd.common.filesystem.rsync.RsyncBasedRecursiveHardLinkMaker;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A fast {@link IImmutableCopier} that uses a fallback option whenever one of the fast copiers for
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/FileOperations.java b/common/source/java/ch/systemsx/cisd/common/filesystem/FileOperations.java
index e4bc94a686d..05934efb59b 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/FileOperations.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/FileOperations.java
@@ -43,7 +43,6 @@ import ch.systemsx.cisd.base.io.AdapterInputStreamToIInputStream;
import ch.systemsx.cisd.base.io.AdapterOutputStreamToIOutputStream;
import ch.systemsx.cisd.base.io.IInputStream;
import ch.systemsx.cisd.base.io.IOutputStream;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.IActivityObserver;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy;
import ch.systemsx.cisd.common.concurrent.RecordingActivityObserverSensor;
@@ -51,6 +50,7 @@ import ch.systemsx.cisd.common.exception.UnknownLastChangedException;
import ch.systemsx.cisd.common.logging.Log4jSimpleLogger;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Monitoring for (potentially hanging) file operations. Supposed to be used on remote file systems.
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/HardLinkMaker.java b/common/source/java/ch/systemsx/cisd/common/filesystem/HardLinkMaker.java
index 90e0c0ee0fb..900df11147d 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/HardLinkMaker.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/HardLinkMaker.java
@@ -28,13 +28,13 @@ import org.springframework.util.FileCopyUtils;
import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
import ch.systemsx.cisd.base.utilities.OSUtilities;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.exception.Status;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.process.CallableExecutor;
import ch.systemsx.cisd.common.process.ProcessExecutionHelper;
import ch.systemsx.cisd.common.process.ProcessResult;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A class for creating hard links based on the Unix 'ln' program.
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/NonHangingFreeSpaceProvider.java b/common/source/java/ch/systemsx/cisd/common/filesystem/NonHangingFreeSpaceProvider.java
index 3c4bb19c5cc..9b2e4bbec48 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/NonHangingFreeSpaceProvider.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/NonHangingFreeSpaceProvider.java
@@ -22,9 +22,9 @@ import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities;
import ch.systemsx.cisd.common.concurrent.ExecutionResult;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A <code>DelegateFreeSpaceProvider</code> which does not block, computing the free space in its
@@ -51,7 +51,7 @@ public final class NonHangingFreeSpaceProvider extends DelegateFreeSpaceProvider
final Future<Long> future =
executorService.submit(new FreeSpaceCallable(getFreeSpaceProvider(), path));
final ExecutionResult<Long> executionResult =
- ConcurrencyUtilities.getResult(future, Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT);
+ ConcurrencyUtilities.getResult(future, TimingParameters.DEFAULT_TIMEOUT_MILLIS);
final Long resultOrNull = executionResult.tryGetResult();
if (resultOrNull != null)
{
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/QueueingPathRemoverService.java b/common/source/java/ch/systemsx/cisd/common/filesystem/QueueingPathRemoverService.java
index b8239909af9..99176e4c869 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/QueueingPathRemoverService.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/QueueingPathRemoverService.java
@@ -25,7 +25,6 @@ import org.apache.log4j.Logger;
import ch.rinn.restrictions.Private;
import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
import ch.systemsx.cisd.base.io.ICloseable;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.collection.ExtendedBlockingQueueFactory;
import ch.systemsx.cisd.common.collection.ExtendedLinkedBlockingQueue;
import ch.systemsx.cisd.common.collection.IExtendedBlockingQueue;
@@ -35,6 +34,7 @@ import ch.systemsx.cisd.common.logging.ISimpleLogger;
import ch.systemsx.cisd.common.logging.Log4jSimpleLogger;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A service for removing (deep) paths. It provides a method {@link #removeRecursively(File)} that
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/highwatermark/HighwaterMarkWatcher.java b/common/source/java/ch/systemsx/cisd/common/filesystem/highwatermark/HighwaterMarkWatcher.java
index afaccaf53b3..ac76835670f 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/highwatermark/HighwaterMarkWatcher.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/highwatermark/HighwaterMarkWatcher.java
@@ -28,7 +28,6 @@ import org.apache.commons.io.FileSystemUtils;
import org.apache.commons.io.FileUtils;
import org.apache.log4j.Logger;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.exception.EnvironmentFailureException;
import ch.systemsx.cisd.common.filesystem.FileUtilities;
import ch.systemsx.cisd.common.filesystem.HostAwareFile;
@@ -38,6 +37,7 @@ import ch.systemsx.cisd.common.filesystem.SimpleFreeSpaceProvider;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.process.CallableExecutor;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A high water mark watcher.
@@ -180,7 +180,7 @@ public final class HighwaterMarkWatcher implements Runnable
final String errorMsg =
String.format("Could not compute available free space for '%s'.", file);
final Long freeSpaceInKb =
- new CallableExecutor(5, Constants.MILLIS_TO_SLEEP_BEFORE_RETRYING)
+ new CallableExecutor(5, TimingParameters.DEFAULT_MILLIS_TO_SLEEP_BEFORE_RETRYING)
.executeCallable(new Callable<Long>()
{
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncBasedRecursiveHardLinkMaker.java b/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncBasedRecursiveHardLinkMaker.java
index f4394eaca24..07124d8f742 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncBasedRecursiveHardLinkMaker.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncBasedRecursiveHardLinkMaker.java
@@ -21,7 +21,6 @@ import java.io.File;
import org.apache.log4j.Logger;
import ch.systemsx.cisd.base.utilities.OSUtilities;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities;
import ch.systemsx.cisd.common.concurrent.InactivityMonitor;
import ch.systemsx.cisd.common.concurrent.InactivityMonitor.IInactivityObserver;
@@ -32,6 +31,7 @@ import ch.systemsx.cisd.common.filesystem.IDirectoryImmutableCopier;
import ch.systemsx.cisd.common.filesystem.RemoteDirectoryCopyActivitySensor;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A hard link maker based on <code>rsync</code>.
diff --git a/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncVersionChecker.java b/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncVersionChecker.java
index b4cef3a3d9b..f30695b84d3 100644
--- a/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncVersionChecker.java
+++ b/common/source/java/ch/systemsx/cisd/common/filesystem/rsync/RsyncVersionChecker.java
@@ -21,12 +21,12 @@ import java.util.List;
import org.apache.log4j.Logger;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.process.ProcessExecutionHelper;
import ch.systemsx.cisd.common.process.ProcessIOStrategy;
import ch.systemsx.cisd.common.process.ProcessResult;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* A class that helps checking an <code>rsync</code> binary for its version.
@@ -241,7 +241,7 @@ final class RsyncVersionChecker
{
final ProcessResult result =
ProcessExecutionHelper.run(Arrays.asList(rsyncExecutableToCheck, "--version"),
- operationLog, machineLog, Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT,
+ operationLog, machineLog, TimingParameters.DEFAULT_TIMEOUT_MILLIS,
ProcessIOStrategy.DEFAULT_IO_STRATEGY, false);
result.log();
final List<String> processOutput = result.getOutput();
diff --git a/common/source/java/ch/systemsx/cisd/common/process/CallableExecutor.java b/common/source/java/ch/systemsx/cisd/common/process/CallableExecutor.java
index f36cf5f5591..d635de6ff77 100644
--- a/common/source/java/ch/systemsx/cisd/common/process/CallableExecutor.java
+++ b/common/source/java/ch/systemsx/cisd/common/process/CallableExecutor.java
@@ -20,7 +20,7 @@ import java.util.concurrent.Callable;
import ch.systemsx.cisd.base.exceptions.CheckedExceptionTunnel;
import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
-import ch.systemsx.cisd.common.Constants;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Executes given {@link Callable}.
@@ -35,7 +35,7 @@ public final class CallableExecutor
public CallableExecutor()
{
- this(Constants.MAXIMUM_RETRY_COUNT, Constants.MILLIS_TO_SLEEP_BEFORE_RETRYING);
+ this(TimingParameters.DEFAULT_MAXIMUM_RETRY_COUNT, TimingParameters.DEFAULT_MILLIS_TO_SLEEP_BEFORE_RETRYING);
}
public CallableExecutor(final int maxRetriesOnFailure, final long millisToSleepOnFailure)
diff --git a/common/source/java/ch/systemsx/cisd/common/TimingParameters.java b/common/source/java/ch/systemsx/cisd/common/time/TimingParameters.java
similarity index 77%
rename from common/source/java/ch/systemsx/cisd/common/TimingParameters.java
rename to common/source/java/ch/systemsx/cisd/common/time/TimingParameters.java
index 2185c818e48..2af4f4f186f 100644
--- a/common/source/java/ch/systemsx/cisd/common/TimingParameters.java
+++ b/common/source/java/ch/systemsx/cisd/common/time/TimingParameters.java
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-package ch.systemsx.cisd.common;
+package ch.systemsx.cisd.common.time;
import java.util.Properties;
@@ -32,9 +32,43 @@ import ch.systemsx.cisd.common.properties.PropertyUtils;
public class TimingParameters
{
+ /** Time in seconds to wait before a timeout occurs. */
+ public static final int DEFAULT_TIMEOUT_SECONDS = 60;
+
+ /** Time interval in seconds to wait after an operation failed before retrying it. */
+ public static final int DEFAULT_INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS = 10;
+
+ /** Maximal number of retries when an operation fails. */
+ public static final int DEFAULT_MAXIMUM_RETRY_COUNT = 11;
+
+ /** Time interval in milli-seconds to wait after an operation failed before retrying it. */
+ public static final long DEFAULT_MILLIS_TO_SLEEP_BEFORE_RETRYING =
+ DEFAULT_INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS * DateUtils.MILLIS_PER_SECOND;
+
+ /** Time in milli-seconds to wait before a timeout occurs.. */
+ public static final long DEFAULT_TIMEOUT_MILLIS =
+ DEFAULT_TIMEOUT_SECONDS * DateUtils.MILLIS_PER_SECOND;
+
+ /**
+ * Name of the property to specify a timeout (in seconds).
+ */
+ public static final String TIMEOUT_PROPERTY_NAME = "timeout";
+
+ /**
+ * Name of the property to specify the maximum number of retries.
+ */
+ public static final String MAX_RETRY_PROPERTY_NAME = "max-retries";
+
+ /**
+ * Name of the property to specify the interval to sleep after a failure and before a retry (in
+ * seconds).
+ */
+ public static final String FAILURE_INTERVAL_NAME = "failure-interval";
+
private final static TimingParameters standardParameters =
- new TimingParameters(Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT,
- Constants.MAXIMUM_RETRY_COUNT, Constants.MILLIS_TO_SLEEP_BEFORE_RETRYING);
+ new TimingParameters(TimingParameters.DEFAULT_TIMEOUT_MILLIS,
+ TimingParameters.DEFAULT_MAXIMUM_RETRY_COUNT,
+ TimingParameters.DEFAULT_MILLIS_TO_SLEEP_BEFORE_RETRYING);
private final static TimingParameters defaultParameters =
new TimingParameters(standardParameters);
@@ -66,12 +100,6 @@ public class TimingParameters
return noTimeoutNoRetriesParameters;
}
- public static final String TIMEOUT_PROPERTY = "timeout";
-
- public static final String MAX_RETRY_PROPERTY = "max-retries";
-
- public static final String FAILURE_INTERVAL = "failure-interval";
-
private volatile long timeoutMillis;
private volatile int maxRetriesOnFailure;
@@ -89,9 +117,9 @@ public class TimingParameters
*/
public static boolean hasTimingParameters(Properties properties)
{
- return properties.containsKey(TIMEOUT_PROPERTY)
- || properties.containsKey(MAX_RETRY_PROPERTY)
- || properties.containsKey(FAILURE_INTERVAL);
+ return properties.containsKey(TIMEOUT_PROPERTY_NAME)
+ || properties.containsKey(MAX_RETRY_PROPERTY_NAME)
+ || properties.containsKey(FAILURE_INTERVAL_NAME);
}
/**
@@ -130,20 +158,22 @@ public class TimingParameters
private static long getIntervalToWaitAfterFailureMillis(Properties properties)
{
- return PropertyUtils.getInt(properties, FAILURE_INTERVAL,
- Constants.INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS)
+ return PropertyUtils.getInt(properties, FAILURE_INTERVAL_NAME,
+ TimingParameters.DEFAULT_INTERVAL_TO_WAIT_AFTER_FAILURE_SECONDS)
* DateUtils.MILLIS_PER_SECOND;
}
private static int getMaxRetriesOnFailure(Properties properties)
{
- return PropertyUtils.getInt(properties, MAX_RETRY_PROPERTY, Constants.MAXIMUM_RETRY_COUNT);
+ return PropertyUtils.getInt(properties, MAX_RETRY_PROPERTY_NAME,
+ TimingParameters.DEFAULT_MAXIMUM_RETRY_COUNT);
}
private static long getTimeoutMillis(Properties properties)
{
final long timeoutSpecified =
- PropertyUtils.getInt(properties, TIMEOUT_PROPERTY, Constants.TIMEOUT_SECONDS)
+ PropertyUtils.getInt(properties, TIMEOUT_PROPERTY_NAME,
+ TimingParameters.DEFAULT_TIMEOUT_SECONDS)
* DateUtils.MILLIS_PER_SECOND;
return (timeoutSpecified == 0) ? Long.MAX_VALUE : timeoutSpecified;
}
@@ -157,8 +187,8 @@ public class TimingParameters
public static TimingParameters create(final long timeoutMillis)
{
- return new TimingParameters(timeoutMillis, Constants.MAXIMUM_RETRY_COUNT,
- Constants.MILLIS_TO_SLEEP_BEFORE_RETRYING);
+ return new TimingParameters(timeoutMillis, TimingParameters.DEFAULT_MAXIMUM_RETRY_COUNT,
+ TimingParameters.DEFAULT_MILLIS_TO_SLEEP_BEFORE_RETRYING);
}
public static TimingParameters createNoRetries(final long timeoutMillis)
diff --git a/common/sourceTest/java/ch/systemsx/cisd/common/TimingParametersTest.java b/common/sourceTest/java/ch/systemsx/cisd/common/TimingParametersTest.java
index 86dc893c885..09656058ab7 100644
--- a/common/sourceTest/java/ch/systemsx/cisd/common/TimingParametersTest.java
+++ b/common/sourceTest/java/ch/systemsx/cisd/common/TimingParametersTest.java
@@ -21,6 +21,8 @@ import java.util.Properties;
import org.apache.commons.lang.time.DateUtils;
import org.testng.annotations.Test;
+import ch.systemsx.cisd.common.time.TimingParameters;
+
import static org.testng.AssertJUnit.*;
/**
@@ -46,9 +48,9 @@ public class TimingParametersTest
final int maxRetries = 7;
final int failureInterval = 13;
final Properties props = new Properties();
- props.put(TimingParameters.TIMEOUT_PROPERTY, Integer.toString(timeout));
- props.put(TimingParameters.MAX_RETRY_PROPERTY, Integer.toString(maxRetries));
- props.put(TimingParameters.FAILURE_INTERVAL, Integer.toString(failureInterval));
+ props.put(TimingParameters.TIMEOUT_PROPERTY_NAME, Integer.toString(timeout));
+ props.put(TimingParameters.MAX_RETRY_PROPERTY_NAME, Integer.toString(maxRetries));
+ props.put(TimingParameters.FAILURE_INTERVAL_NAME, Integer.toString(failureInterval));
final TimingParameters parameters = TimingParameters.create(props);
assertEquals(timeout * DateUtils.MILLIS_PER_SECOND, parameters.getTimeoutMillis());
assertEquals(maxRetries, parameters.getMaxRetriesOnFailure());
@@ -67,7 +69,7 @@ public class TimingParametersTest
public void testHasTimingParametersTrue()
{
final Properties props = new Properties();
- props.put(TimingParameters.TIMEOUT_PROPERTY, "30");
+ props.put(TimingParameters.TIMEOUT_PROPERTY_NAME, "30");
assertTrue(TimingParameters.hasTimingParameters(props));
}
@@ -75,7 +77,7 @@ public class TimingParametersTest
public void testHasTimingParametersTrue2()
{
final Properties props = new Properties();
- props.put(TimingParameters.MAX_RETRY_PROPERTY, "2");
+ props.put(TimingParameters.MAX_RETRY_PROPERTY_NAME, "2");
assertTrue(TimingParameters.hasTimingParameters(props));
}
@@ -83,7 +85,7 @@ public class TimingParametersTest
public void testHasTimingParametersTrue3()
{
final Properties props = new Properties();
- props.put(TimingParameters.FAILURE_INTERVAL, "xxx");
+ props.put(TimingParameters.FAILURE_INTERVAL_NAME, "xxx");
assertTrue(TimingParameters.hasTimingParameters(props));
}
}
diff --git a/common/sourceTest/java/ch/systemsx/cisd/common/concurrent/MonitoringProxyTest.java b/common/sourceTest/java/ch/systemsx/cisd/common/concurrent/MonitoringProxyTest.java
index b448812726d..6057f4f54e5 100644
--- a/common/sourceTest/java/ch/systemsx/cisd/common/concurrent/MonitoringProxyTest.java
+++ b/common/sourceTest/java/ch/systemsx/cisd/common/concurrent/MonitoringProxyTest.java
@@ -40,12 +40,12 @@ import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
import ch.systemsx.cisd.base.exceptions.TimeoutExceptionUnchecked;
import ch.systemsx.cisd.base.namedthread.NamingThreadPoolExecutor;
import ch.systemsx.cisd.base.tests.Retry50;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy.IMonitorCommunicator;
import ch.systemsx.cisd.common.logging.AssertingLogger;
import ch.systemsx.cisd.common.logging.ConsoleLogger;
import ch.systemsx.cisd.common.logging.ISimpleLogger;
import ch.systemsx.cisd.common.logging.LogLevel;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Test cases for the {@link MonitoringProxy}.
diff --git a/common/sourceTest/java/ch/systemsx/cisd/common/filesystem/FileOperationsTest.java b/common/sourceTest/java/ch/systemsx/cisd/common/filesystem/FileOperationsTest.java
index a4a60b70d62..ac5c0975586 100644
--- a/common/sourceTest/java/ch/systemsx/cisd/common/filesystem/FileOperationsTest.java
+++ b/common/sourceTest/java/ch/systemsx/cisd/common/filesystem/FileOperationsTest.java
@@ -31,12 +31,12 @@ import ch.systemsx.cisd.base.exceptions.TimeoutExceptionUnchecked;
import ch.systemsx.cisd.base.io.IInputStream;
import ch.systemsx.cisd.base.tests.AbstractFileSystemTestCase;
import ch.systemsx.cisd.base.tests.Retry10;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities;
import ch.systemsx.cisd.common.concurrent.IActivityObserver;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy;
import ch.systemsx.cisd.common.concurrent.RecordingActivityObserverSensor;
import ch.systemsx.cisd.common.logging.Log4jSimpleLogger;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Test cases for {@link FileOperations}.
diff --git a/common/sourceTest/java/ch/systemsx/cisd/common/reflection/ClassUtilsTest.java b/common/sourceTest/java/ch/systemsx/cisd/common/reflection/ClassUtilsTest.java
index 19d4182218f..1d780ef2503 100644
--- a/common/sourceTest/java/ch/systemsx/cisd/common/reflection/ClassUtilsTest.java
+++ b/common/sourceTest/java/ch/systemsx/cisd/common/reflection/ClassUtilsTest.java
@@ -34,9 +34,9 @@ import java.util.Properties;
import org.testng.annotations.Test;
import org.testng.remote.SuiteSlave;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.TimingParametersTest;
import ch.systemsx.cisd.common.reflection.ClassUtils;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Test cases for the {@link ClassUtils} class.
diff --git a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/RetryingPathRemover.java b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/RetryingPathRemover.java
index 2c1d49b529a..e53eeea0c26 100644
--- a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/RetryingPathRemover.java
+++ b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/RetryingPathRemover.java
@@ -26,7 +26,6 @@ import org.apache.log4j.Logger;
import ch.rinn.restrictions.Private;
import ch.systemsx.cisd.base.namedthread.NamingThreadPoolExecutor;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities;
import ch.systemsx.cisd.common.concurrent.ExecutionResult;
import ch.systemsx.cisd.common.concurrent.ExecutionStatus;
@@ -38,6 +37,7 @@ import ch.systemsx.cisd.common.exception.Status;
import ch.systemsx.cisd.common.filesystem.FileUtilities;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.datamover.filesystem.intf.IPathRemover;
/**
@@ -50,7 +50,7 @@ import ch.systemsx.cisd.datamover.filesystem.intf.IPathRemover;
final class RetryingPathRemover implements IPathRemover
{
private static final long DELETE_ONE_FILE_TIMEOUT_MILLIS =
- Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT;
+ TimingParameters.DEFAULT_TIMEOUT_MILLIS;
private static final Logger operationLog =
LogFactory.getLogger(LogCategory.OPERATION, RetryingPathRemover.class);
diff --git a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/intf/AbstractFileStore.java b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/intf/AbstractFileStore.java
index 04d19647877..941090294b0 100644
--- a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/intf/AbstractFileStore.java
+++ b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/intf/AbstractFileStore.java
@@ -23,7 +23,6 @@ import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang.builder.EqualsBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.EnvironmentFailureException;
import ch.systemsx.cisd.common.exception.Status;
@@ -32,6 +31,7 @@ import ch.systemsx.cisd.common.filesystem.FileUtilities;
import ch.systemsx.cisd.common.filesystem.IPathCopier;
import ch.systemsx.cisd.common.filesystem.StoreItem;
import ch.systemsx.cisd.common.filesystem.highwatermark.HostAwareFileWithHighwaterMark;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.datamover.DatamoverConstants;
/**
@@ -233,7 +233,7 @@ public abstract class AbstractFileStore implements IFileStore
public void check() throws EnvironmentFailureException, ConfigurationFailureException
{
final BooleanStatus result =
- checkDirectoryFullyAccessible(Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT);
+ checkDirectoryFullyAccessible(TimingParameters.DEFAULT_TIMEOUT_MILLIS);
if (result.isSuccess() == false)
{
throw new ConfigurationFailureException(result.tryGetMessage());
diff --git a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/remote/RemotePathMover.java b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/remote/RemotePathMover.java
index 92c41149e76..72e32d05b61 100644
--- a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/remote/RemotePathMover.java
+++ b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/remote/RemotePathMover.java
@@ -18,7 +18,6 @@ package ch.systemsx.cisd.datamover.filesystem.remote;
import org.apache.log4j.Logger;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.concurrent.InactivityMonitor;
import ch.systemsx.cisd.common.concurrent.InactivityMonitor.IInactivityObserver;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
@@ -30,6 +29,7 @@ import ch.systemsx.cisd.common.logging.ConditionalNotificationLogger;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.logging.LogLevel;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.datamover.common.IStoreMover;
import ch.systemsx.cisd.datamover.common.MarkerFile;
import ch.systemsx.cisd.datamover.filesystem.intf.IExtendedFileStore;
@@ -191,7 +191,7 @@ public final class RemotePathMover implements IStoreMover
{
final BooleanStatus status =
destinationStore
- .checkDirectoryFullyAccessible(Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT);
+ .checkDirectoryFullyAccessible(TimingParameters.DEFAULT_TIMEOUT_MILLIS);
if (status.isSuccess() == false)
{
conditionalLogger.log(LogLevel.ERROR, status.tryGetMessage());
diff --git a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/FileStoreRemoteMounted.java b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/FileStoreRemoteMounted.java
index 37046b959ef..c3a77fb8945 100644
--- a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/FileStoreRemoteMounted.java
+++ b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/FileStoreRemoteMounted.java
@@ -17,7 +17,6 @@
package ch.systemsx.cisd.datamover.filesystem.store;
import ch.systemsx.cisd.base.exceptions.TimeoutExceptionUnchecked;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.EnvironmentFailureException;
@@ -29,6 +28,7 @@ import ch.systemsx.cisd.common.filesystem.highwatermark.HighwaterMarkWatcher;
import ch.systemsx.cisd.common.filesystem.highwatermark.HostAwareFileWithHighwaterMark;
import ch.systemsx.cisd.common.logging.ISimpleLogger;
import ch.systemsx.cisd.common.logging.LogLevel;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.datamover.filesystem.intf.AbstractFileStore;
import ch.systemsx.cisd.datamover.filesystem.intf.IExtendedFileStore;
import ch.systemsx.cisd.datamover.filesystem.intf.IFileStore;
diff --git a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/RemoteFreeSpaceProvider.java b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/RemoteFreeSpaceProvider.java
index bdea16e64b7..b16f5274243 100644
--- a/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/RemoteFreeSpaceProvider.java
+++ b/datamover/source/java/ch/systemsx/cisd/datamover/filesystem/store/RemoteFreeSpaceProvider.java
@@ -22,7 +22,6 @@ import java.util.List;
import org.apache.commons.lang.StringUtils;
import org.apache.log4j.Logger;
-import ch.systemsx.cisd.common.Constants;
import ch.systemsx.cisd.common.filesystem.HostAwareFile;
import ch.systemsx.cisd.common.filesystem.IFreeSpaceProvider;
import ch.systemsx.cisd.common.filesystem.ssh.ISshCommandBuilder;
@@ -30,6 +29,7 @@ import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.process.ProcessExecutionHelper;
import ch.systemsx.cisd.common.process.ProcessResult;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* An <code>IFreeSpaceProvider</code> implementation for computing the free space on a remote
@@ -51,7 +51,7 @@ final class RemoteFreeSpaceProvider implements IFreeSpaceProvider
private final ISshCommandBuilder sshCommandBuilder;
- private final long millisToWaitForCompletion = Constants.MILLIS_TO_WAIT_BEFORE_TIMEOUT;
+ private final long millisToWaitForCompletion = TimingParameters.DEFAULT_TIMEOUT_MILLIS;
public RemoteFreeSpaceProvider(final ISshCommandBuilder sshCommandBuilder)
{
diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/ETLDaemon.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/ETLDaemon.java
index 146d5ce2d90..a1d7263520b 100644
--- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/ETLDaemon.java
+++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/ETLDaemon.java
@@ -35,7 +35,6 @@ import org.apache.log4j.Logger;
import ch.rinn.restrictions.Private;
import ch.systemsx.cisd.base.exceptions.CheckedExceptionTunnel;
import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.TimerUtilities;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.HighLevelException;
@@ -67,6 +66,7 @@ import ch.systemsx.cisd.common.maintenance.MaintenanceTaskParameters;
import ch.systemsx.cisd.common.maintenance.MaintenanceTaskUtils;
import ch.systemsx.cisd.common.properties.PropertyUtils;
import ch.systemsx.cisd.common.reflection.ClassUtils;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.common.utilities.IExitHandler;
import ch.systemsx.cisd.common.utilities.ISelfTestable;
import ch.systemsx.cisd.common.utilities.SystemExit;
diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/FileBasedFileFactory.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/FileBasedFileFactory.java
index 556fbd7a134..15f357be262 100644
--- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/FileBasedFileFactory.java
+++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/FileBasedFileFactory.java
@@ -20,9 +20,9 @@ import java.io.File;
import org.apache.commons.io.FilenameUtils;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.filesystem.FastRecursiveHardLinkMaker;
import ch.systemsx.cisd.common.filesystem.IImmutableCopier;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* File factory based on {@link File}. Files are copies by creating hard links (if possible) if the
diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/Parameters.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/Parameters.java
index 00c4dbb9577..0b3fb9f379b 100644
--- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/Parameters.java
+++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/Parameters.java
@@ -25,7 +25,6 @@ import ch.systemsx.cisd.args4j.CmdLineException;
import ch.systemsx.cisd.args4j.CmdLineParser;
import ch.systemsx.cisd.args4j.ExampleMode;
import ch.systemsx.cisd.args4j.Option;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.UserFailureException;
import ch.systemsx.cisd.common.logging.LogCategory;
@@ -37,6 +36,7 @@ import ch.systemsx.cisd.common.properties.ExtendedProperties;
import ch.systemsx.cisd.common.properties.PropertyParametersUtil;
import ch.systemsx.cisd.common.properties.PropertyUtils;
import ch.systemsx.cisd.common.properties.PropertyParametersUtil.SectionProperties;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.common.utilities.IExitHandler;
import ch.systemsx.cisd.common.utilities.SystemExit;
import ch.systemsx.cisd.common.utilities.VoidExitHandler;
diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/QueueingDataSetStatusUpdaterService.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/QueueingDataSetStatusUpdaterService.java
index 3c5c27a6775..a1ca3dd6760 100644
--- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/QueueingDataSetStatusUpdaterService.java
+++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/QueueingDataSetStatusUpdaterService.java
@@ -24,7 +24,6 @@ import org.springframework.remoting.RemoteAccessException;
import ch.systemsx.cisd.base.exceptions.InterruptedExceptionUnchecked;
import ch.systemsx.cisd.base.io.ICloseable;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.collection.CollectionUtils;
import ch.systemsx.cisd.common.collection.ExtendedBlockingQueueFactory;
import ch.systemsx.cisd.common.collection.IExtendedBlockingQueue;
@@ -33,6 +32,7 @@ import ch.systemsx.cisd.common.collection.QueuePersister;
import ch.systemsx.cisd.common.exception.UserFailureException;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.openbis.dss.generic.shared.dto.DataSetCodesWithStatus;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.DataSetArchivingStatus;
diff --git a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/FileBasedFileTest.java b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/FileBasedFileTest.java
index 95968568d63..b92e8388c0f 100644
--- a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/FileBasedFileTest.java
+++ b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/FileBasedFileTest.java
@@ -24,9 +24,9 @@ import java.io.File;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.filesystem.FileUtilities;
import ch.systemsx.cisd.common.logging.LogInitializer;
+import ch.systemsx.cisd.common.time.TimingParameters;
/**
* Test cases for corresponding {@link FileBasedFile} class.
diff --git a/deep_sequencing_unit/source/java/ch/ethz/bsse/cisd/dsu/dss/FlowLaneFeeder.java b/deep_sequencing_unit/source/java/ch/ethz/bsse/cisd/dsu/dss/FlowLaneFeeder.java
index 8fd80986cd6..6c876e96576 100644
--- a/deep_sequencing_unit/source/java/ch/ethz/bsse/cisd/dsu/dss/FlowLaneFeeder.java
+++ b/deep_sequencing_unit/source/java/ch/ethz/bsse/cisd/dsu/dss/FlowLaneFeeder.java
@@ -38,7 +38,6 @@ import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang.time.DateFormatUtils;
import org.apache.log4j.Logger;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.ConcurrencyUtilities;
import ch.systemsx.cisd.common.exception.ConfigurationFailureException;
import ch.systemsx.cisd.common.exception.EnvironmentFailureException;
@@ -56,6 +55,7 @@ import ch.systemsx.cisd.common.process.ProcessIOStrategy;
import ch.systemsx.cisd.common.process.ProcessResult;
import ch.systemsx.cisd.common.properties.ExtendedProperties;
import ch.systemsx.cisd.common.properties.PropertyUtils;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.etlserver.AbstractPostRegistrationDataSetHandlerForFileBasedUndo;
import ch.systemsx.cisd.openbis.dss.generic.shared.IEncapsulatedOpenBISService;
import ch.systemsx.cisd.openbis.dss.generic.shared.dto.DataSetInformation;
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/business/DataStoreServiceFactory.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/business/DataStoreServiceFactory.java
index 3fb67825393..e629fb0bc02 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/business/DataStoreServiceFactory.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/business/DataStoreServiceFactory.java
@@ -28,13 +28,13 @@ import org.springframework.remoting.RemoteAccessException;
import ch.systemsx.cisd.base.exceptions.CheckedExceptionTunnel;
import ch.systemsx.cisd.base.namedthread.NamingThreadPoolExecutor;
-import ch.systemsx.cisd.common.TimingParameters;
import ch.systemsx.cisd.common.concurrent.MonitoringProxy;
import ch.systemsx.cisd.common.logging.Log4jSimpleLogger;
import ch.systemsx.cisd.common.logging.LogCategory;
import ch.systemsx.cisd.common.logging.LogFactory;
import ch.systemsx.cisd.common.logging.LogLevel;
import ch.systemsx.cisd.common.spring.HttpInvokerUtils;
+import ch.systemsx.cisd.common.time.TimingParameters;
import ch.systemsx.cisd.openbis.generic.shared.IDataStoreService;
/**
--
GitLab