diff --git a/common/source/java/ch/systemsx/cisd/common/interpreter/PythonInterpreter.java b/common/source/java/ch/systemsx/cisd/common/interpreter/PythonInterpreter.java index ec5198cfc6b7cf18ecf9601edc38c623351c0091..705c773566e04ee53cee91549e95574615bb44c4 100644 --- a/common/source/java/ch/systemsx/cisd/common/interpreter/PythonInterpreter.java +++ b/common/source/java/ch/systemsx/cisd/common/interpreter/PythonInterpreter.java @@ -22,7 +22,7 @@ import org.python.core.PySystemState; import ch.systemsx.cisd.common.logging.LogCategory; import ch.systemsx.cisd.common.logging.LogFactory; -import ch.systemsx.cisd.common.resource.Resource; +import ch.systemsx.cisd.common.resource.IResource; import ch.systemsx.cisd.common.resource.Resources; /** @@ -49,9 +49,9 @@ public class PythonInterpreter extends org.python.util.PythonInterpreter public void set(String name, Object value) { super.set(name, value); - if (value instanceof Resource) + if (value instanceof IResource) { - resources.add((Resource) value); + resources.add((IResource) value); } } @@ -59,9 +59,9 @@ public class PythonInterpreter extends org.python.util.PythonInterpreter public void set(String name, PyObject value) { super.set(name, value); - if (value instanceof Resource) + if (value instanceof IResource) { - resources.add((Resource) value); + resources.add((IResource) value); } } diff --git a/common/source/java/ch/systemsx/cisd/common/resource/Resource.java b/common/source/java/ch/systemsx/cisd/common/resource/IResource.java similarity index 96% rename from common/source/java/ch/systemsx/cisd/common/resource/Resource.java rename to common/source/java/ch/systemsx/cisd/common/resource/IResource.java index 0225fb0f277ec30705a117352615afe10ba020bf..1342844b39894c2a61a91018ed47e8e0ef20a1d2 100644 --- a/common/source/java/ch/systemsx/cisd/common/resource/Resource.java +++ b/common/source/java/ch/systemsx/cisd/common/resource/IResource.java @@ -19,7 +19,7 @@ package ch.systemsx.cisd.common.resource; /** * @author pkupczyk */ -public interface Resource +public interface IResource { public void release(); diff --git a/common/source/java/ch/systemsx/cisd/common/resource/Resources.java b/common/source/java/ch/systemsx/cisd/common/resource/Resources.java index 376e9c8f25bbb803eba3d262e9ec145ca91f991f..c1c61a11f0324d9483418103adbb5369ee7deb0e 100644 --- a/common/source/java/ch/systemsx/cisd/common/resource/Resources.java +++ b/common/source/java/ch/systemsx/cisd/common/resource/Resources.java @@ -29,14 +29,14 @@ public class Resources private Logger logger; - public Set<Resource> resources = new LinkedHashSet<Resource>(); + public Set<IResource> resources = new LinkedHashSet<IResource>(); public Resources(Logger logger) { this.logger = logger; } - public void add(Resource resource) + public void add(IResource resource) { resources.add(resource); } @@ -45,7 +45,7 @@ public class Resources { if (resources.size() > 0) { - for (Resource resource : resources) + for (IResource resource : resources) { try { diff --git a/common/sourceTest/java/ch/systemsx/cisd/common/resource/ResourcesTest.java b/common/sourceTest/java/ch/systemsx/cisd/common/resource/ResourcesTest.java index 19a39b7228a4019aefca5cd977c9306f97fe309b..f5fbd3ad63554347a592b56f9c102b7d15e678ad 100644 --- a/common/sourceTest/java/ch/systemsx/cisd/common/resource/ResourcesTest.java +++ b/common/sourceTest/java/ch/systemsx/cisd/common/resource/ResourcesTest.java @@ -31,10 +31,10 @@ public class ResourcesTest { Mockery context = new Mockery(); - final Resource failingResource1 = context.mock(Resource.class, "failingResource1"); - final Resource failingResource2 = context.mock(Resource.class, "failingResource2"); - final Resource notFailingResource1 = context.mock(Resource.class, "notFailingResource1"); - final Resource notFailingResource2 = context.mock(Resource.class, "notFailingResource2"); + final IResource failingResource1 = context.mock(IResource.class, "failingResource1"); + final IResource failingResource2 = context.mock(IResource.class, "failingResource2"); + final IResource notFailingResource1 = context.mock(IResource.class, "notFailingResource1"); + final IResource notFailingResource2 = context.mock(IResource.class, "notFailingResource2"); Resources resources = new Resources(null); resources.add(notFailingResource1); @@ -67,7 +67,7 @@ public class ResourcesTest { Mockery context = new Mockery(); - final Resource resource = context.mock(Resource.class); + final IResource resource = context.mock(IResource.class); Resources resources = new Resources(null); resources.add(resource); @@ -90,7 +90,7 @@ public class ResourcesTest { Mockery context = new Mockery(); - final Resource resource = context.mock(Resource.class); + final IResource resource = context.mock(IResource.class); Resources resources = new Resources(null); resources.add(resource); diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/TopLevelDataSetRegistratorGlobalState.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/TopLevelDataSetRegistratorGlobalState.java index 36db21883d681fe35696c503a9bfc9e15b50eedd..fbb890c2cf945c28228829515116613e9a94785c 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/TopLevelDataSetRegistratorGlobalState.java +++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/TopLevelDataSetRegistratorGlobalState.java @@ -26,7 +26,7 @@ import org.apache.log4j.Logger; import ch.systemsx.cisd.common.logging.LogCategory; import ch.systemsx.cisd.common.logging.LogFactory; import ch.systemsx.cisd.common.mail.IMailClient; -import ch.systemsx.cisd.common.resource.Resource; +import ch.systemsx.cisd.common.resource.IResource; import ch.systemsx.cisd.common.shared.basic.utils.StringUtils; import ch.systemsx.cisd.common.utilities.PropertyUtils; import ch.systemsx.cisd.etlserver.registrator.recovery.IDataSetStorageRecoveryManager; @@ -40,7 +40,7 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.dto.Person; * * @author Chandrasekhar Ramakrishnan */ -public class TopLevelDataSetRegistratorGlobalState implements Resource +public class TopLevelDataSetRegistratorGlobalState implements IResource { // can be used from dropboxes public static final Logger operationLog = LogFactory.getLogger(LogCategory.OPERATION, @@ -417,9 +417,9 @@ public class TopLevelDataSetRegistratorGlobalState implements Resource @Override public void release() { - if (getDataSourceQueryService() instanceof Resource) + if (getDataSourceQueryService() instanceof IResource) { - ((Resource) getDataSourceQueryService()).release(); + ((IResource) getDataSourceQueryService()).release(); } } diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/DataSourceQueryService.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/DataSourceQueryService.java index 7f780a87741d595dd1a9c186a1fdc0a0dbbd64bf..3626cc695cc20f5c0280e9b9d498dd2a1f82ff1b 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/DataSourceQueryService.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/shared/DataSourceQueryService.java @@ -28,14 +28,14 @@ import org.apache.log4j.Logger; import ch.systemsx.cisd.common.logging.LogCategory; import ch.systemsx.cisd.common.logging.LogFactory; -import ch.systemsx.cisd.common.resource.Resource; +import ch.systemsx.cisd.common.resource.IResource; import ch.systemsx.cisd.common.resource.Resources; import ch.systemsx.cisd.openbis.dss.generic.shared.api.internal.v1.IDataSourceQueryService; /** * @author Chandrasekhar Ramakrishnan */ -public class DataSourceQueryService implements IDataSourceQueryService, Resource +public class DataSourceQueryService implements IDataSourceQueryService, IResource { private static final Logger operationLog = LogFactory.getLogger(LogCategory.OPERATION, DataSourceQueryService.class); @@ -82,7 +82,7 @@ public class DataSourceQueryService implements IDataSourceQueryService, Resource resources.clear(); } - private static class DataSetResource implements Resource + private static class DataSetResource implements IResource { private DataSet<?> dataSet;