From a7250d8a38912a16cc807ebf8bee023b4cd7dd4e Mon Sep 17 00:00:00 2001
From: tpylak <tpylak>
Date: Tue, 29 Mar 2011 09:16:17 +0000
Subject: [PATCH] refactoring: remove unused parameter
SVN: 20527
---
.../web/server/resultset/AbstractTableModelProvider.java | 5 ++---
.../web/server/resultset/AuthorizationGroupProvider.java | 2 +-
.../client/web/server/resultset/FileFormatTypesProvider.java | 2 +-
.../client/web/server/resultset/MaterialProvider.java | 2 +-
.../generic/client/web/server/resultset/PersonsProvider.java | 2 +-
.../client/web/server/resultset/ProjectsProvider.java | 2 +-
.../client/web/server/resultset/RoleAssignmentProvider.java | 2 +-
.../generic/client/web/server/resultset/SampleProvider.java | 2 +-
.../generic/client/web/server/resultset/ScriptProvider.java | 2 +-
.../generic/client/web/server/resultset/SpacesProvider.java | 2 +-
.../client/web/server/resultset/VocabulariesProvider.java | 2 +-
.../client/web/server/resultset/VocabularyTermsProvider.java | 2 +-
.../client/web/server/resultset/QueryExpressionProvider.java | 2 +-
.../web/server/resultset/RoleAssignmentProviderTest.java | 2 +-
.../client/web/server/resultset/ScriptProviderTest.java | 2 +-
.../screening/client/web/server/PlateMetadataProvider.java | 2 +-
.../screening/client/web/server/WellContentProvider.java | 2 +-
17 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AbstractTableModelProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AbstractTableModelProvider.java
index 4ef63c7d91b..ba38c5a7f88 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AbstractTableModelProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AbstractTableModelProvider.java
@@ -40,7 +40,7 @@ public abstract class AbstractTableModelProvider<T extends ISerializable> implem
*/
public TypedTableModel<T> getTableModel(int maxSize)
{
- TypedTableModel<T> tableModel = createTableModel(Integer.MAX_VALUE);
+ TypedTableModel<T> tableModel = createTableModel();
List<TableModelColumnHeader> headers = tableModel.getHeader();
List<TableModelRowWithObject<T>> rows = tableModel.getRows();
List<TableModelRowWithObject<T>> limitedRows = new ArrayList<TableModelRowWithObject<T>>();
@@ -57,8 +57,7 @@ public abstract class AbstractTableModelProvider<T extends ISerializable> implem
/**
* Creates the complete table model.
- * @param maxSize TODO
*/
- protected abstract TypedTableModel<T> createTableModel(int maxSize);
+ protected abstract TypedTableModel<T> createTableModel();
}
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AuthorizationGroupProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AuthorizationGroupProvider.java
index 91a6e7588b3..c8916345f86 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AuthorizationGroupProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/AuthorizationGroupProvider.java
@@ -42,7 +42,7 @@ public class AuthorizationGroupProvider extends AbstractCommonTableModelProvider
}
@Override
- protected TypedTableModel<AuthorizationGroup> createTableModel(int maxSize)
+ protected TypedTableModel<AuthorizationGroup> createTableModel()
{
List<AuthorizationGroup> groups = commonServer.listAuthorizationGroups(sessionToken);
TypedTableModelBuilder<AuthorizationGroup> builder =
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/FileFormatTypesProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/FileFormatTypesProvider.java
index 6afc08d1d0a..ea88ba19f6e 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/FileFormatTypesProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/FileFormatTypesProvider.java
@@ -38,7 +38,7 @@ public class FileFormatTypesProvider extends AbstractCommonTableModelProvider<Fi
}
@Override
- protected TypedTableModel<FileFormatType> createTableModel(int maxSize)
+ protected TypedTableModel<FileFormatType> createTableModel()
{
List<FileFormatType> fileFormats = commonServer.listFileFormatTypes(sessionToken);
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/MaterialProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/MaterialProvider.java
index 8764597a1eb..af20885d9af 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/MaterialProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/MaterialProvider.java
@@ -44,7 +44,7 @@ public class MaterialProvider extends AbstractTableModelProvider<Material>
}
@Override
- protected TypedTableModel<Material> createTableModel(int maxSize)
+ protected TypedTableModel<Material> createTableModel()
{
TypedTableModelBuilder<Material> builder = new TypedTableModelBuilder<Material>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/PersonsProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/PersonsProvider.java
index 5f692d8030b..4315e874e18 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/PersonsProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/PersonsProvider.java
@@ -48,7 +48,7 @@ public class PersonsProvider extends AbstractCommonTableModelProvider<Person>
}
@Override
- protected TypedTableModel<Person> createTableModel(int maxSize)
+ protected TypedTableModel<Person> createTableModel()
{
List<Person> persons;
if (authorizationGroupIdOrNull == null)
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ProjectsProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ProjectsProvider.java
index 7380246d893..5b0fc2204bb 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ProjectsProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ProjectsProvider.java
@@ -43,7 +43,7 @@ public class ProjectsProvider extends AbstractCommonTableModelProvider<Project>
}
@Override
- protected TypedTableModel<Project> createTableModel(int maxSize)
+ protected TypedTableModel<Project> createTableModel()
{
List<Project> projects = commonServer.listProjects(sessionToken);
TypedTableModelBuilder<Project> builder = new TypedTableModelBuilder<Project>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProvider.java
index 75ef6c627ea..915fa0bf67c 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProvider.java
@@ -47,7 +47,7 @@ public class RoleAssignmentProvider extends AbstractCommonTableModelProvider<Rol
}
@Override
- protected TypedTableModel<RoleAssignment> createTableModel(int maxSize)
+ protected TypedTableModel<RoleAssignment> createTableModel()
{
List<RoleAssignment> roles = commonServer.listRoleAssignments(sessionToken);
TypedTableModelBuilder<RoleAssignment> builder = new TypedTableModelBuilder<RoleAssignment>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SampleProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SampleProvider.java
index 20e39ca47a8..19bab51b8f9 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SampleProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SampleProvider.java
@@ -70,7 +70,7 @@ public class SampleProvider extends AbstractCommonTableModelProvider<Sample>
}
@Override
- protected TypedTableModel<Sample> createTableModel(int maxSize)
+ protected TypedTableModel<Sample> createTableModel()
{
List<Sample> samples = getSamples();
TypedTableModelBuilder<Sample> builder = new TypedTableModelBuilder<Sample>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProvider.java
index 0816678ad9a..16df63953f8 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProvider.java
@@ -52,7 +52,7 @@ public class ScriptProvider extends AbstractCommonTableModelProvider<Script>
}
@Override
- protected TypedTableModel<Script> createTableModel(int maxSize)
+ protected TypedTableModel<Script> createTableModel()
{
List<Script> scripts = commonServer.listScripts(sessionToken, scriptTypeOrNull, entityKindOrNull);
TypedTableModelBuilder<Script> builder = new TypedTableModelBuilder<Script>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SpacesProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SpacesProvider.java
index 25887e588eb..ab687ebda08 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SpacesProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/SpacesProvider.java
@@ -42,7 +42,7 @@ public class SpacesProvider extends AbstractCommonTableModelProvider<Space>
}
@Override
- protected TypedTableModel<Space> createTableModel(int maxSize)
+ protected TypedTableModel<Space> createTableModel()
{
DatabaseInstanceIdentifier identifier = new DatabaseInstanceIdentifier(null);
List<Space> spaces = commonServer.listSpaces(sessionToken, identifier);
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabulariesProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabulariesProvider.java
index c80b4973333..fc2e14b7d54 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabulariesProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabulariesProvider.java
@@ -51,7 +51,7 @@ public class VocabulariesProvider extends AbstractCommonTableModelProvider<Vocab
}
@Override
- protected TypedTableModel<Vocabulary> createTableModel(int maxSize)
+ protected TypedTableModel<Vocabulary> createTableModel()
{
List<Vocabulary> vocabularies =
commonServer.listVocabularies(sessionToken, withTerms, excludeInternal);
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabularyTermsProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabularyTermsProvider.java
index a3d9672e818..fac647a6ce7 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabularyTermsProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/VocabularyTermsProvider.java
@@ -57,7 +57,7 @@ public class VocabularyTermsProvider extends AbstractCommonTableModelProvider<Vo
}
@Override
- protected TypedTableModel<VocabularyTermWithStats> createTableModel(int maxSize)
+ protected TypedTableModel<VocabularyTermWithStats> createTableModel()
{
TypedTableModelBuilder<VocabularyTermWithStats> builder =
new TypedTableModelBuilder<VocabularyTermWithStats>();
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/plugin/query/client/web/server/resultset/QueryExpressionProvider.java b/openbis/source/java/ch/systemsx/cisd/openbis/plugin/query/client/web/server/resultset/QueryExpressionProvider.java
index e0fcaea0925..b9df7049127 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/plugin/query/client/web/server/resultset/QueryExpressionProvider.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/plugin/query/client/web/server/resultset/QueryExpressionProvider.java
@@ -54,7 +54,7 @@ public class QueryExpressionProvider extends AbstractTableModelProvider<QueryExp
}
@Override
- protected TypedTableModel<QueryExpression> createTableModel(int maxSize)
+ protected TypedTableModel<QueryExpression> createTableModel()
{
List<QueryExpression> expressions = server.listQueries(sessionToken,
QueryType.UNSPECIFIED, BasicEntityType.UNSPECIFIED);
diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProviderTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProviderTest.java
index 3455cbc11f7..fa59b8c51ce 100644
--- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProviderTest.java
+++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/RoleAssignmentProviderTest.java
@@ -66,7 +66,7 @@ public class RoleAssignmentProviderTest extends AbstractProviderTest
});
RoleAssignmentProvider provider = new RoleAssignmentProvider(server, SESSION_TOKEN);
- TypedTableModel<RoleAssignment> model = provider.createTableModel(Integer.MAX_VALUE);
+ TypedTableModel<RoleAssignment> model = provider.createTableModel();
assertEquals("[PERSON, AUTHORIZATION_GROUP, SPACE, ROLE, DATABASE_INSTANCE]",
getHeaderIDs(model).toString());
diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProviderTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProviderTest.java
index 9f680dc20e5..b784c10d557 100644
--- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProviderTest.java
+++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/client/web/server/resultset/ScriptProviderTest.java
@@ -55,7 +55,7 @@ public class ScriptProviderTest extends AbstractProviderTest
new ScriptProvider(server, SESSION_TOKEN, ScriptType.DYNAMIC_PROPERTY,
EntityKind.EXPERIMENT);
- TypedTableModel<Script> tableModel = scriptProvider.createTableModel(Integer.MAX_VALUE);
+ TypedTableModel<Script> tableModel = scriptProvider.createTableModel();
assertEquals(
"[NAME, DESCRIPTION, SCRIPT, ENTITY_KIND, SCRIPT_TYPE, REGISTRATOR, REGISTRATION_DATE]",
diff --git a/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/PlateMetadataProvider.java b/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/PlateMetadataProvider.java
index b867e8f8a11..0a682370db8 100644
--- a/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/PlateMetadataProvider.java
+++ b/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/PlateMetadataProvider.java
@@ -52,7 +52,7 @@ class PlateMetadataProvider extends AbstractTableModelProvider<WellMetadata>
}
@Override
- public TypedTableModel<WellMetadata> createTableModel(int maxSize)
+ public TypedTableModel<WellMetadata> createTableModel()
{
TypedTableModelBuilder<WellMetadata> builder = new TypedTableModelBuilder<WellMetadata>();
PlateContent plateContent = server.getPlateContent(sessionToken, plateId);
diff --git a/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/WellContentProvider.java b/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/WellContentProvider.java
index 5a9bd70879c..3cfc45e26b4 100644
--- a/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/WellContentProvider.java
+++ b/screening/source/java/ch/systemsx/cisd/openbis/plugin/screening/client/web/server/WellContentProvider.java
@@ -71,7 +71,7 @@ public class WellContentProvider extends AbstractTableModelProvider<WellContent>
}
@Override
- protected TypedTableModel<WellContent> createTableModel(int maxSize)
+ protected TypedTableModel<WellContent> createTableModel()
{
TypedTableModelBuilder<WellContent> builder = new TypedTableModelBuilder<WellContent>();
addStandardWellColumns(builder);
--
GitLab