diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/EmailSender.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/EmailSender.java index 0705f96eb4fc8d6901b57c3c4fca6e6f8aaba829..db4945abfa9df7ef5b3e0f33ae0f7a79ea8f347d 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/EmailSender.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/EmailSender.java @@ -64,6 +64,10 @@ public class EmailSender implements IEmailSender public IEmailSender withAttachedFile(String filePath, String attachmentName) { + if (attachmentName == null) + { + throw new IllegalArgumentException("Unspecified attachment name."); + } if (attachmentTextOrNull != null) { throw new IllegalStateException("Attachment text was already set."); @@ -75,6 +79,10 @@ public class EmailSender implements IEmailSender public IEmailSender withAttachedText(String text, String attachmentName) { + if (attachmentName == null) + { + throw new IllegalArgumentException("Unspecified attachment name."); + } if (attachmentFilePathOrNull != null) { throw new IllegalStateException("Attachment file path was already set."); @@ -84,6 +92,14 @@ public class EmailSender implements IEmailSender return this; } + @Override + public String toString() + { + return "EmailSender [subject=" + subject + ", bodyText=" + bodyText + + ", attachmentNameOrNull=" + attachmentNameOrNull + ", attachmentFilePathOrNull=" + + attachmentFilePathOrNull + ", attachmentTextOrNull=" + attachmentTextOrNull + "]"; + } + // sender public void send() diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/PluginScriptRunner.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/PluginScriptRunner.java index d2be4ab35fd6169b4347f6e70ad20aee40639e3a..1ca236f2c1a04dc0aa909a681096f69d9405b4e0 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/PluginScriptRunner.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/PluginScriptRunner.java @@ -138,7 +138,7 @@ class PluginScriptRunner private static ISearchService createSearchService() { - return ServiceProvider.getSearchServiceProvider(); + return ServiceProvider.getSearchService(); } private static IMailService createMailService(DataSetProcessingContext context) diff --git a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/api/IEmailSender.java b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/api/IEmailSender.java index 8621f821882352e6caa08de884a536222cfd174d..8bd4b51e0892e26d6987448387eb17fc578b5e5e 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/api/IEmailSender.java +++ b/datastore_server/source/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/jython/api/IEmailSender.java @@ -28,9 +28,9 @@ public interface IEmailSender IEmailSender withBody(String bodyText); - IEmailSender withAttachedFile(String attachmentFilePath, String attachmentName); + IEmailSender withAttachedFile(String attachmentFilePath, String attachmentFileName); - IEmailSender withAttachedText(String attachmentText, String attachmentName); + IEmailSender withAttachedText(String attachmentText, String attachmentFileName); void send(); }