From a152fb800bbd1af0b7545f87cd2173a87c59091d Mon Sep 17 00:00:00 2001
From: buczekp <buczekp>
Date: Fri, 14 Jan 2011 12:50:01 +0000
Subject: [PATCH] [LMS-1949] fixed tests and moved them to correct package
SVN: 19425
---
.../shared}/SimpleTableModelBuilderTest.java | 2 +-
.../EICMLChromatogramImagesReporter.java | 6 ++--
.../eicml/EICMLChromatogramsReporter.java | 18 +++++------
.../cisd/yeastx/eicml/EICMLRunsReporter.java | 30 +++++--------------
4 files changed, 20 insertions(+), 36 deletions(-)
rename {datastore_server/sourceTest/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/tasks => openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/shared}/SimpleTableModelBuilderTest.java (99%)
diff --git a/datastore_server/sourceTest/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/tasks/SimpleTableModelBuilderTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/shared/SimpleTableModelBuilderTest.java
similarity index 99%
rename from datastore_server/sourceTest/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/tasks/SimpleTableModelBuilderTest.java
rename to openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/shared/SimpleTableModelBuilderTest.java
index 600914152fe..1dbfe6a6c59 100644
--- a/datastore_server/sourceTest/java/ch/systemsx/cisd/openbis/dss/generic/server/plugins/tasks/SimpleTableModelBuilderTest.java
+++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/shared/SimpleTableModelBuilderTest.java
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-package ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks;
+package ch.systemsx.cisd.openbis.generic.shared;
import java.util.Arrays;
import java.util.List;
diff --git a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramImagesReporter.java b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramImagesReporter.java
index 76b6f0bd654..7e7e233acb4 100644
--- a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramImagesReporter.java
+++ b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramImagesReporter.java
@@ -26,7 +26,6 @@ import java.util.Properties;
import net.lemnik.eodsql.DataIterator;
import ch.rinn.restrictions.Private;
-import ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder;
import ch.systemsx.cisd.openbis.dss.yeastx.server.EICMLChromatogramGeneratorServlet;
import ch.systemsx.cisd.openbis.generic.shared.GenericSharedConstants;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.GeneratedImageTableCell;
@@ -34,6 +33,7 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.dto.ISerializableComparable
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.TableModel;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.TableModelRow;
import ch.systemsx.cisd.openbis.generic.shared.dto.DatasetDescription;
+import ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder;
/**
* Reporting plugin which shows images for the chromatograms contained in the specified datasets.
@@ -172,9 +172,9 @@ public class EICMLChromatogramImagesReporter extends AbstractEICMLDatastoreRepor
String chromatogramLabel = chromatogram.getLabel();
row.add(SimpleTableModelBuilder.asText(chromatogramLabel));
int mz1 = getMz1(chromatogramLabel);
- row.add(SimpleTableModelBuilder.asNum(mz1));
+ row.add(SimpleTableModelBuilder.asInteger(mz1));
int mz2 = getMz2(chromatogramLabel);
- row.add(SimpleTableModelBuilder.asNum(mz2));
+ row.add(SimpleTableModelBuilder.asInteger(mz2));
row.add(imageCell);
return row;
}
diff --git a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramsReporter.java b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramsReporter.java
index 8785555b1c3..29b266a7b8b 100644
--- a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramsReporter.java
+++ b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLChromatogramsReporter.java
@@ -16,8 +16,8 @@
package ch.systemsx.cisd.yeastx.eicml;
-import static ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder.asNum;
-import static ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder.asText;
+import static ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder.asDouble;
+import static ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder.asText;
import java.io.File;
import java.util.ArrayList;
@@ -26,10 +26,10 @@ import java.util.Properties;
import net.lemnik.eodsql.DataIterator;
-import ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.ISerializableComparable;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.TableModel;
import ch.systemsx.cisd.openbis.generic.shared.dto.DatasetDescription;
+import ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder;
/**
* Reporting plugin which shows all the chromatograms details for the chosen datasets.
@@ -88,12 +88,12 @@ public class EICMLChromatogramsReporter extends AbstractEICMLDatastoreReportingP
List<ISerializableComparable> row = new ArrayList<ISerializableComparable>();
row.add(asText(chromatogram.getLabel()));
- row.add(asNum(calcMin(chromatogram.getRunTimes())));
- row.add(asNum(calcMax(chromatogram.getRunTimes())));
- row.add(asNum(calcMax(chromatogram.getIntensities())));
- row.add(asNum(chromatogram.getQ1Mz()));
- row.add(asNum(chromatogram.getQ3LowMz()));
- row.add(asNum(chromatogram.getQ3HighMz()));
+ row.add(asDouble(calcMin(chromatogram.getRunTimes())));
+ row.add(asDouble(calcMax(chromatogram.getRunTimes())));
+ row.add(asDouble(calcMax(chromatogram.getIntensities())));
+ row.add(asDouble(chromatogram.getQ1Mz()));
+ row.add(asDouble(chromatogram.getQ3LowMz()));
+ row.add(asDouble(chromatogram.getQ3HighMz()));
row.add(asText("" + chromatogram.getPolarity()));
return row;
}
diff --git a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLRunsReporter.java b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLRunsReporter.java
index 69f0cef0de6..fd6e9e8e5ca 100644
--- a/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLRunsReporter.java
+++ b/rtd_yeastx/source/java/ch/systemsx/cisd/yeastx/eicml/EICMLRunsReporter.java
@@ -16,25 +16,26 @@
package ch.systemsx.cisd.yeastx.eicml;
-import static ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder.asNum;
+import static ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder.asDate;
+import static ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder.asDouble;
+import static ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder.asText;
import java.io.File;
import java.util.ArrayList;
-import java.util.Date;
import java.util.List;
import java.util.Properties;
-import ch.systemsx.cisd.openbis.dss.generic.server.plugins.tasks.SimpleTableModelBuilder;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.ISerializableComparable;
import ch.systemsx.cisd.openbis.generic.shared.basic.dto.TableModel;
import ch.systemsx.cisd.openbis.generic.shared.dto.DatasetDescription;
+import ch.systemsx.cisd.openbis.generic.shared.util.SimpleTableModelBuilder;
/**
* Reporting plugin which shows all the run details for the chosen datasets.
*
* @author Tomasz Pylak
*/
-public class EICMLRunsReporter extends AbstractEICMLDatastoreReportingPlugin
+public class EICMLRunsReporter extends AbstractEICMLDatastoreReportingPlugin
{
private static final long serialVersionUID = 1L;
@@ -72,29 +73,12 @@ public class EICMLRunsReporter extends AbstractEICMLDatastoreReportingPlugin
row.add(asText(run.getMethodIonisation()));
row.add(asText(run.getMethodSeparation()));
row.add(asDate(run.getAcquisitionDate()));
- row.add(asNum(run.getStartTime()));
- row.add(asNum(run.getEndTime()));
+ row.add(asDouble(run.getStartTime()));
+ row.add(asDouble(run.getEndTime()));
row.add(asText(run.getOperator()));
return row;
}
- private static ISerializableComparable asDate(Date dateOrNull)
- {
- if (dateOrNull != null)
- {
- return SimpleTableModelBuilder.asDate(dateOrNull);
- } else
- {
- return SimpleTableModelBuilder.asText("");
- }
- }
-
- private static ISerializableComparable asText(String textOrNull)
- {
- String text = textOrNull == null ? "" : textOrNull;
- return SimpleTableModelBuilder.asText(text);
- }
-
private static void addReportHeaders(SimpleTableModelBuilder builder)
{
builder.addHeader("Dataset");
--
GitLab