diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/TypedTableGrid.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/TypedTableGrid.java index 6e5225f7193814889aafdde6e8c6f77094134f68..181e3e551a9c0edc195f74f558a9e3285530ebed 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/TypedTableGrid.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/TypedTableGrid.java @@ -231,27 +231,16 @@ public abstract class TypedTableGrid<T extends ISerializable> { for (TableModelColumnHeader header : headers) { - String id = header.getId(); - if (tryGetCellListenerAndLinkGenerator(id) != null) + final String id = header.getId(); + final GridCellRenderer<BaseEntityModel<?>> specificRendererOrNull = + tryGetSpecificRenderer(header.getDataType(), header.getIndex()); + if (specificRendererOrNull != null) { - final GridCellRenderer<BaseEntityModel<?>> specificRendererOrNull = - tryGetSpecificRenderer(header.getDataType(), header.getIndex()); - if (specificRendererOrNull != null) - { - definitions.setGridCellRendererFor(id, specificRendererOrNull); - } else - { - definitions.setGridCellRendererFor(id, - LinkRenderer.createLinkRenderer(true, header.getIndex())); - } - } else + definitions.setGridCellRendererFor(id, specificRendererOrNull); + } else if (tryGetCellListenerAndLinkGenerator(id) != null) { - final GridCellRenderer<BaseEntityModel<?>> specificRendererOrNull = - tryGetSpecificRenderer(header.getDataType(), header.getIndex()); - if (specificRendererOrNull != null) - { - definitions.setGridCellRendererFor(id, specificRendererOrNull); - } + definitions.setGridCellRendererFor(id, + LinkRenderer.createLinkRenderer(true, header.getIndex())); } } } diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnUtils.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnUtils.java index e82d54f74ebf2c3ebcaae121952af433c23f4e9b..7e95119d16a8d1facc7fcb2384956182bcb4b835 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnUtils.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/grid/ColumnUtils.java @@ -61,6 +61,7 @@ public class ColumnUtils { final CellEditor editor; DataTypeCode dataType = column.tryToGetDataType(); + assert dataType != null; switch (dataType) { case INTEGER: diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/TableCellUtil.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/TableCellUtil.java index f966eac92a82257767e27951ef0469903d8ee3ce..653b0ec033ae24c987da71dcca7b277af9370cbc 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/TableCellUtil.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/basic/TableCellUtil.java @@ -85,10 +85,12 @@ public class TableCellUtil case TIMESTAMP: case CONTROLLEDVOCABULARY: case MATERIAL: + case HYPERLINK: return true; - default: + case XML: return false; } + throw new UnsupportedOperationException(""); // not possible } private TableCellUtil()