From 962ada5a98fe4651a7838fa66365d3973465d91e Mon Sep 17 00:00:00 2001 From: gpawel <gpawel> Date: Fri, 29 Jul 2011 14:27:57 +0000 Subject: [PATCH] [LMS-2421] fixing unit tests SVN: 22301 --- .../plugin/generic/SampleBrowsingTest.java | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/plugin/generic/SampleBrowsingTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/plugin/generic/SampleBrowsingTest.java index 0a746a617c7..66922256756 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/plugin/generic/SampleBrowsingTest.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/plugin/generic/SampleBrowsingTest.java @@ -17,7 +17,6 @@ package ch.systemsx.cisd.openbis.systemtest.plugin.generic; import static org.testng.AssertJUnit.assertEquals; -import static org.testng.AssertJUnit.assertNotNull; import static org.testng.AssertJUnit.assertNull; import static org.testng.AssertJUnit.fail; @@ -106,8 +105,7 @@ public class SampleBrowsingTest extends GenericSystemTestCase .getIdentifier()); } - @Test(groups = "broken") - // FIXME LMS-2421 + @Test public final void testListMasterPlates() { logIntoCommonClientService(); @@ -124,11 +122,6 @@ public class SampleBrowsingTest extends GenericSystemTestCase GridRowModels<Sample> list = samples.getResultSet().getList(); - Sample s1 = getSample(list, createSampleIdentifier("MP001-1")); - checkInternalProperty(s1.getProperties(), "PLATE_GEOMETRY", DEFAULT_PLATE_GEOMETRY_VALUE); - assertNotNull(s1.getDeletion()); - assertNull(s1.getExperiment()); - Sample s2 = getSample(list, createSampleIdentifier("MP002-1")); checkInternalProperty(s2.getProperties(), "PLATE_GEOMETRY", DEFAULT_PLATE_GEOMETRY_VALUE); assertNull(s2.getDeletion()); @@ -157,8 +150,7 @@ public class SampleBrowsingTest extends GenericSystemTestCase assertNull(s.getExperiment()); } - @Test(groups = "broken") - // FIXME LMS-2421 + @Test public final void testListCellPlates() { logIntoCommonClientService(); @@ -175,10 +167,10 @@ public class SampleBrowsingTest extends GenericSystemTestCase GridRowModels<Sample> list = samples.getResultSet().getList(); - Sample s = getSample(list, createSampleIdentifier("3VCP1")); - assertNotNull(s.getDeletion()); - assertEquals("/CISD/NEMO/EXP1", s.getExperiment().getIdentifier()); - assertEquals("/CISD/3V-123", s.getGeneratedFrom().getIdentifier()); + Sample s = getSample(list, createSampleIdentifier("3VCP5")); + // assertNotNull(s.getDeletion()); + assertEquals("/CISD/NEMO/EXP10", s.getExperiment().getIdentifier()); + assertEquals("/CISD/3V-125", s.getGeneratedFrom().getIdentifier()); assertNull(s.getGeneratedFrom().getGeneratedFrom()); } -- GitLab