diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/validator/AbstractCollectionValidator.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/validator/AbstractCollectionValidator.java index ec10eb69103463818871267557150b85746c47e2..ece3758d378f56e365c128e68666eaf8e133d5b2 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/validator/AbstractCollectionValidator.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/server/authorization/validator/AbstractCollectionValidator.java @@ -40,6 +40,7 @@ public abstract class AbstractCollectionValidator<T> implements ICollectionValid @Override public boolean isValid(PersonPE person, T value) { + assert person != null; Collection<T> valid = getValid(person, Arrays.asList(value)); return false == valid.isEmpty(); } diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultAccessControllerTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultAccessControllerTest.java index 6ba41054fd14f52ef7e721988b2eccfeafe3d3d5..552b4345731f405f78bb2280cb2271cca9bda7f2 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultAccessControllerTest.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/authorization/DefaultAccessControllerTest.java @@ -116,9 +116,12 @@ public final class DefaultAccessControllerTest context.checking(new Expectations() { { + allowing(authorizationConfig).isProjectLevelEnabled(); + will(returnValue(false)); + allowing(daoFactory).getAuthorizationConfig(); will(returnValue(authorizationConfig)); - + allowing(daoFactory).getProjectDAO(); will(returnValue(projectDAO)); diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/GridCustomFilterDAOTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/GridCustomFilterDAOTest.java index d9eca3340e5d09c2293e64cd23296b4114fe8cc8..5d59f85a652e7759eb21b1f176f234af08ab9deb 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/GridCustomFilterDAOTest.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/generic/server/dataaccess/db/GridCustomFilterDAOTest.java @@ -16,6 +16,7 @@ package ch.systemsx.cisd.openbis.generic.server.dataaccess.db; +import java.util.Collections; import java.util.List; import org.testng.AssertJUnit; @@ -48,12 +49,13 @@ public final class GridCustomFilterDAOTest extends AbstractDAOTest @Test public void testCreateFilter() throws Exception { - AssertJUnit.assertEquals(0, daoFactory.getGridCustomFilterDAO().listAllEntities().size()); + AssertJUnit.assertEquals(1, daoFactory.getGridCustomFilterDAO().listAllEntities().size()); GridCustomFilterPE filter = createFilter(NAME, GRID, DESCRIPTION, EXPRESSION, PUBLIC, getSystemPerson()); daoFactory.getGridCustomFilterDAO().createFilter(filter); List<GridCustomFilterPE> filters = daoFactory.getGridCustomFilterDAO().listAllEntities(); - AssertJUnit.assertEquals(1, filters.size()); + Collections.sort(filters); + AssertJUnit.assertEquals(2, filters.size()); AssertJUnit.assertEquals(filter, filters.get(0)); } diff --git a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/authorization/ProjectAuthorizationMigrationTest.java b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/authorization/ProjectAuthorizationMigrationTest.java index b31efda255ec5a58089ccfecbbc41a52ad01bfa9..6bbb7c95f83d09ff1e53d7e507ef27d8981b44dd 100644 --- a/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/authorization/ProjectAuthorizationMigrationTest.java +++ b/openbis/sourceTest/java/ch/systemsx/cisd/openbis/systemtest/authorization/ProjectAuthorizationMigrationTest.java @@ -179,6 +179,7 @@ public class ProjectAuthorizationMigrationTest extends SystemTestCase private static IAuthSessionProvider createSessionWithRoles(RoleWithHierarchy... roles) { PersonPE person = new PersonPE(); + person.setUserId("some_user_with_pa_on"); for (RoleWithHierarchy role : roles) {