From 7d029d0bfbebf8d8affc3a409451f727f42cde3c Mon Sep 17 00:00:00 2001
From: vermeul <swen@ethz.ch>
Date: Tue, 12 Mar 2019 16:57:49 +0100
Subject: [PATCH] checking attributes when creating new samples

---
 pybis/src/python/pybis/sample.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/pybis/src/python/pybis/sample.py b/pybis/src/python/pybis/sample.py
index 079210e8ffb..a9198ec5eee 100644
--- a/pybis/src/python/pybis/sample.py
+++ b/pybis/src/python/pybis/sample.py
@@ -4,6 +4,8 @@ from .openbis_object import OpenBisObject
 from .definitions import openbis_definitions
 from .utils import VERBOSE
 
+sample_definitions = openbis_definitions('Sample')
+
 class Sample(OpenBisObject):
     """ A Sample is one of the most commonly used objects in openBIS.
     """
@@ -26,6 +28,8 @@ class Sample(OpenBisObject):
 
         if kwargs is not None:
             for key in kwargs:
+                if key not in sample_definitions['attrs_new']:
+                    raise ValueError("{} is not a valid attribute for a Sample".format(key))
                 setattr(self, key, kwargs[key])
 
         if getattr(self, 'parents') is None:
-- 
GitLab