From 72f91dfc6b9f2bef86d9faa3bf7a9c3288115473 Mon Sep 17 00:00:00 2001
From: tpylak <tpylak>
Date: Fri, 11 Mar 2011 14:28:04 +0000
Subject: [PATCH] minor: more telling error message
SVN: 20310
---
.../predicate/AbstractSpacePredicate.java | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/authorization/predicate/AbstractSpacePredicate.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/authorization/predicate/AbstractSpacePredicate.java
index 725928bec04..daac9634940 100644
--- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/authorization/predicate/AbstractSpacePredicate.java
+++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/shared/authorization/predicate/AbstractSpacePredicate.java
@@ -57,16 +57,21 @@ public abstract class AbstractSpacePredicate<T> extends AbstractDatabaseInstance
{
if (tryFindSpace(databaseInstanceUUID, spaceCodeOrNull) == null)
{
- return Status.createError(String.format("User '%s' does not have enough privileges.",
- person.getUserId()));
+ return createError(person, spaceCodeOrNull);
}
final boolean matching = isMatching(allowedRoles, databaseInstanceUUID, spaceCodeOrNull);
if (matching)
{
return Status.OK;
}
- return Status.createError(String.format("User '%s' does not have enough privileges.",
- person.getUserId()));
+ return createError(person, spaceCodeOrNull);
+ }
+
+ private Status createError(final PersonPE person, final String spaceCodeOrNull)
+ {
+ return Status.createError(String.format(
+ "User '%s' does not have enough privileges or space %s does not exist.",
+ person.getUserId(), spaceCodeOrNull));
}
private SpacePE tryFindSpace(final String databaseInstanceUUID, final String spaceCode)
--
GitLab