From 2d64f1c70fcb89a103ae72d5a0b9ad50a8fc461d Mon Sep 17 00:00:00 2001
From: tpylak <tpylak>
Date: Mon, 3 Dec 2007 11:13:49 +0000
Subject: [PATCH] BDS review todos
SVN: 2888
---
bds/source/java/ch/systemsx/cisd/bds/ExperimentIdentifier.java | 1 +
bds/source/java/ch/systemsx/cisd/bds/storage/IDirectory.java | 3 +++
.../java/ch/systemsx/cisd/bds/storage/filesystem/File.java | 1 +
.../ch/systemsx/cisd/bds/storage/filesystem/ILinkMaker.java | 1 +
4 files changed, 6 insertions(+)
diff --git a/bds/source/java/ch/systemsx/cisd/bds/ExperimentIdentifier.java b/bds/source/java/ch/systemsx/cisd/bds/ExperimentIdentifier.java
index b07bd1dd719..94a3493dd59 100644
--- a/bds/source/java/ch/systemsx/cisd/bds/ExperimentIdentifier.java
+++ b/bds/source/java/ch/systemsx/cisd/bds/ExperimentIdentifier.java
@@ -75,6 +75,7 @@ public class ExperimentIdentifier implements IStorable
/**
* Returns the group code;
*/
+ // TODO 2007-12-03 Tomasz Pylak review: should not we use the term organization as everywhere else instead of group?
public final String getGroupCode()
{
return groupCode;
diff --git a/bds/source/java/ch/systemsx/cisd/bds/storage/IDirectory.java b/bds/source/java/ch/systemsx/cisd/bds/storage/IDirectory.java
index 90195b00029..4965eb31033 100644
--- a/bds/source/java/ch/systemsx/cisd/bds/storage/IDirectory.java
+++ b/bds/source/java/ch/systemsx/cisd/bds/storage/IDirectory.java
@@ -48,6 +48,9 @@ public interface IDirectory extends INode, Iterable<INode>
* @return the new node. It will be a {@link ILink} if <code>file</code> is a symbolic link, a {@link IDirectory}
* if <code>file</code> is a folder, or {@link IFile} if <code>file</code> is a plain file.
*/
+ // TODO 2007-12-03 Tomasz Pylak review: this generic interface should not use java.io.File. Is the 'move' parameter
+ // possible to implement in HDF5? Maybe those operations should be done before, depending on the implementation
+ // which is used?
public INode addFile(final File file, final boolean move);
/**
diff --git a/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/File.java b/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/File.java
index 791d86e8828..22cf9aab659 100644
--- a/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/File.java
+++ b/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/File.java
@@ -34,6 +34,7 @@ import ch.systemsx.cisd.common.utilities.FileUtilities;
*
* @author Franz-Josef Elmer
*/
+// TODO 2007-12-03 Tomasz Pylak review: Name of this class should be changed, it's very confusing
final class File extends AbstractNode implements IFile
{
File(final java.io.File file)
diff --git a/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/ILinkMaker.java b/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/ILinkMaker.java
index 81d1e80d612..ca8995183b8 100644
--- a/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/ILinkMaker.java
+++ b/bds/source/java/ch/systemsx/cisd/bds/storage/filesystem/ILinkMaker.java
@@ -42,6 +42,7 @@ public interface ILinkMaker
public final File tryCreateLink(final File file, final File destDir, final String nameOrNull)
throws EnvironmentFailureException
{
+ // TODO 2007-12-03 Tomasz Pylak review: should not we just make a copy here?
return null;
}
};
--
GitLab