From 26781b65cd3a200fba26daed11390b9eb3d178d7 Mon Sep 17 00:00:00 2001 From: izabel <izabel> Date: Wed, 10 Mar 2010 14:48:56 +0000 Subject: [PATCH] minor: unify TODO formats SVN: 15106 --- .../web/client/application/ui/LoginPanelAutofill.java | 7 ++++--- .../web/server/calculator/ComparableCellValueHelper.java | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/LoginPanelAutofill.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/LoginPanelAutofill.java index cff81edcd5c..226aded44fe 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/LoginPanelAutofill.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/client/application/ui/LoginPanelAutofill.java @@ -42,15 +42,16 @@ import ch.systemsx.cisd.openbis.generic.client.web.client.dto.SessionContext; * This class uses a variant of a trick described in the GWT discussion forum to support autofill. * Browsers do not support autofill on input fields that are generated on the client by javascript, * so it is necessary for the page to statically contain the input fields we want to autofill. These - * fields are unhidden and used on the login page. TODO This implementation currently supports - * Firefox, but not Safari or Chrome. To support Safari, we cannot use javascript in the action, - * instead we need to have the login post data to a server. + * fields are unhidden and used on the login page. * * @see <a href * ="http://groups.google.com/group/Google-Web-Toolkit/browse%5Fthread/thread/2b2ce0b6aaa82461">GWT * Discussion Forum</a> * @author Chandrasekhar Ramakrishnan */ +// TODO 2010-03-10, CR: This implementation currently supports Firefox, but not Safari or Chrome. To +// support Safari, we cannot use javascript in the action, instead we need to have the login post +// data to a server. public class LoginPanelAutofill extends VerticalPanel { private final IViewContext<ICommonClientServiceAsync> viewContext; diff --git a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/calculator/ComparableCellValueHelper.java b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/calculator/ComparableCellValueHelper.java index 38d6e1bde9a..5aa4ac8b328 100644 --- a/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/calculator/ComparableCellValueHelper.java +++ b/openbis/source/java/ch/systemsx/cisd/openbis/generic/client/web/server/calculator/ComparableCellValueHelper.java @@ -27,8 +27,8 @@ import ch.systemsx.cisd.openbis.generic.shared.basic.dto.IntegerTableCell; public class ComparableCellValueHelper { - // TODO CR --This code should be a method on ISerializableComparable and implemented using - // polymorphism. + // TODO 2010-03-10, CR: This code should be a method on ISerializableComparable and implemented + // using polymorphism. public static Comparable<?> unwrap(ISerializableComparable cellValue) { if (cellValue instanceof DateTableCell) -- GitLab