diff --git a/datastore_server/.project b/datastore_server/.project index 00cc0ce1d8c9a90b30354ecb6f95f062ad5aa01e..a32726a11ca7638c12df47028d66675b1a6ba2fd 100644 --- a/datastore_server/.project +++ b/datastore_server/.project @@ -26,4 +26,15 @@ <nature>com.atlassw.tools.eclipse.checkstyle.CheckstyleNature</nature> <nature>org.python.pydev.pythonNature</nature> </natures> + <filteredResources> + <filter> + <id>1332345981463</id> + <name></name> + <type>26</type> + <matcher> + <id>org.eclipse.ui.ide.multiFilter</id> + <arguments>1.0-name-matches-false-false-.git</arguments> + </matcher> + </filter> + </filteredResources> </projectDescription> diff --git a/datastore_server/source/java/ch/systemsx/cisd/etlserver/registrator/AbstractOmniscientTopLevelDataSetRegistrator.java b/datastore_server/source/java/ch/systemsx/cisd/etlserver/registrator/AbstractOmniscientTopLevelDataSetRegistrator.java index 2d0cf54b834a8e845aed4a1d6da5e20727ba295d..a91a68b04bbd01fb7a4ddbb5468a070a82cd8109 100644 --- a/datastore_server/source/java/ch/systemsx/cisd/etlserver/registrator/AbstractOmniscientTopLevelDataSetRegistrator.java +++ b/datastore_server/source/java/ch/systemsx/cisd/etlserver/registrator/AbstractOmniscientTopLevelDataSetRegistrator.java @@ -47,8 +47,6 @@ import ch.systemsx.cisd.etlserver.AbstractTopLevelDataSetRegistrator; import ch.systemsx.cisd.etlserver.DataStrategyStore; import ch.systemsx.cisd.etlserver.DssUniqueFilenameGenerator; import ch.systemsx.cisd.etlserver.IDataStrategyStore; -import ch.systemsx.cisd.etlserver.IPostRegistrationAction; -import ch.systemsx.cisd.etlserver.IPreRegistrationAction; import ch.systemsx.cisd.etlserver.IStorageProcessorTransactional; import ch.systemsx.cisd.etlserver.IStorageProcessorTransactional.UnstoreDataAction; import ch.systemsx.cisd.etlserver.ITopLevelDataSetRegistratorDelegate; @@ -57,8 +55,6 @@ import ch.systemsx.cisd.etlserver.TopLevelDataSetRegistratorGlobalState; import ch.systemsx.cisd.etlserver.registrator.IDataSetOnErrorActionDecision.ErrorType; import ch.systemsx.cisd.etlserver.registrator.api.v1.SecondaryTransactionFailure; import ch.systemsx.cisd.etlserver.registrator.api.v1.impl.DataSetRegistrationTransaction; -import ch.systemsx.cisd.etlserver.utils.PostRegistrationExecutor; -import ch.systemsx.cisd.etlserver.utils.PreRegistrationExecutor; import ch.systemsx.cisd.openbis.dss.generic.shared.api.v1.validation.ValidationError; import ch.systemsx.cisd.openbis.dss.generic.shared.api.v1.validation.ValidationScriptRunner; import ch.systemsx.cisd.openbis.dss.generic.shared.dto.DataSetInformation; diff --git a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/AbstractJythonDataSetHandlerTest.java b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/AbstractJythonDataSetHandlerTest.java index d068afa68bf2d6297d48f3c09bf40c28ffc69f46..7dae23f73f6dd5112d558e7a53c8516bb56e6264 100644 --- a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/AbstractJythonDataSetHandlerTest.java +++ b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/AbstractJythonDataSetHandlerTest.java @@ -29,39 +29,26 @@ import net.lemnik.eodsql.DynamicTransactionQuery; import org.apache.commons.io.FileUtils; import org.jmock.Expectations; import org.jmock.Mockery; -import org.python.core.PyFunction; -import org.python.util.PythonInterpreter; import org.testng.annotations.AfterMethod; import org.testng.annotations.AfterTest; import org.testng.annotations.BeforeMethod; import org.testng.annotations.BeforeTest; -import ch.systemsx.cisd.base.exceptions.CheckedExceptionTunnel; import ch.systemsx.cisd.base.exceptions.IOExceptionUnchecked; import ch.systemsx.cisd.base.tests.AbstractFileSystemTestCase; -import ch.systemsx.cisd.common.exceptions.UserFailureException; import ch.systemsx.cisd.common.filesystem.FileOperations; import ch.systemsx.cisd.common.filesystem.QueueingPathRemoverService; import ch.systemsx.cisd.common.mail.IMailClient; import ch.systemsx.cisd.common.utilities.ExtendedProperties; -import ch.systemsx.cisd.common.utilities.IDelegatedActionWithResult; import ch.systemsx.cisd.etlserver.DynamicTransactionQueryFactory; import ch.systemsx.cisd.etlserver.IStorageProcessorTransactional; -import ch.systemsx.cisd.etlserver.ITopLevelDataSetRegistratorDelegate; import ch.systemsx.cisd.etlserver.ITypeExtractor; import ch.systemsx.cisd.etlserver.ThreadParameters; import ch.systemsx.cisd.etlserver.TopLevelDataSetRegistratorGlobalState; -import ch.systemsx.cisd.etlserver.registrator.JythonTopLevelDataSetHandler.JythonDataSetRegistrationService; -import ch.systemsx.cisd.etlserver.registrator.api.v1.SecondaryTransactionFailure; -import ch.systemsx.cisd.etlserver.registrator.api.v1.impl.DataSetRegistrationTransaction; import ch.systemsx.cisd.etlserver.validation.IDataSetValidator; import ch.systemsx.cisd.openbis.dss.generic.shared.IEncapsulatedOpenBISService; import ch.systemsx.cisd.openbis.dss.generic.shared.api.internal.v1.IDataSourceQueryService; -import ch.systemsx.cisd.openbis.dss.generic.shared.dto.AtomicEntityOperationDetails; -import ch.systemsx.cisd.openbis.dss.generic.shared.dto.DataSetInformation; import ch.systemsx.cisd.openbis.generic.shared.basic.dto.DatabaseInstance; -import ch.systemsx.cisd.openbis.generic.shared.dto.AtomicEntityOperationResult; -import ch.systemsx.cisd.openbis.generic.shared.dto.NewExternalData; import ch.systemsx.cisd.openbis.generic.shared.dto.StorageFormat; /** diff --git a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/JythonTopLevelDataSetRegistratorTest.java b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/JythonTopLevelDataSetRegistratorTest.java index 66c7c463800d8a575f66c21d0fb3c9257ac67231..8a69f3de8bb0e68d106d64a223d6b7a92c45a7bc 100644 --- a/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/JythonTopLevelDataSetRegistratorTest.java +++ b/datastore_server/sourceTest/java/ch/systemsx/cisd/etlserver/registrator/JythonTopLevelDataSetRegistratorTest.java @@ -43,7 +43,6 @@ import ch.systemsx.cisd.common.eodsql.MockDataSet; import ch.systemsx.cisd.common.exceptions.ConfigurationFailureException; import ch.systemsx.cisd.common.exceptions.UserFailureException; import ch.systemsx.cisd.common.filesystem.FileUtilities; -import ch.systemsx.cisd.common.logging.BufferedAppender; import ch.systemsx.cisd.common.test.RecordingMatcher; import ch.systemsx.cisd.common.utilities.IDelegatedAction; import ch.systemsx.cisd.common.utilities.IPredicate; @@ -95,15 +94,11 @@ public class JythonTopLevelDataSetRegistratorTest extends AbstractJythonDataSetH private static final String SAMPLE_PERM_ID = "sample-perm-id"; - private BufferedAppender logAppender; - @BeforeMethod @Override public void setUp() throws IOException { super.setUp(); - - logAppender = new BufferedAppender(); } public ArrayList<TestCaseParameters> multipleVersionsOfTestCase(TestCaseParameters params) @@ -114,10 +109,10 @@ public class JythonTopLevelDataSetRegistratorTest extends AbstractJythonDataSetH return list; } - public TestCaseParameters versionV2(TestCaseParameters params) + public TestCaseParameters versionV2(final TestCaseParameters other) { - params = params.clone(); - params.overrideProperties = (HashMap<String, String>) params.overrideProperties.clone(); + TestCaseParameters params = other.clone(); + params.overrideProperties = new HashMap<String, String>(params.overrideProperties); params.overrideProperties.put("TEST_V2_API", ""); params.title += " - V2"; return params; @@ -396,7 +391,7 @@ public class JythonTopLevelDataSetRegistratorTest extends AbstractJythonDataSetH { this.title = title; this.overrideProperties = new HashMap<String, String>(); - }; + } @Override public TestCaseParameters clone()