diff --git a/screening/source/core-plugins/cellomics/1/dss/drop-boxes/cellomics-dropbox/cellomics-dropbox.py b/screening/source/core-plugins/cellomics/1/dss/drop-boxes/cellomics-dropbox/cellomics-dropbox.py index b42ad8595b8e85c1ca4e693ecd3874b922840f3b..0a6fb23f902480c1ab43bb48e796cffde0c555b2 100644 --- a/screening/source/core-plugins/cellomics/1/dss/drop-boxes/cellomics-dropbox/cellomics-dropbox.py +++ b/screening/source/core-plugins/cellomics/1/dss/drop-boxes/cellomics-dropbox/cellomics-dropbox.py @@ -82,7 +82,6 @@ if incoming.isDirectory(): imageDataset.setRawImageDatasetType() imageDataset.setGenerateThumbnails(True) imageDataset.setUseImageMagicToGenerateThumbnails(False) - imageDataset.setPlate(SPACE_CODE, PLATE_CODE) imageDataset.setImageLibrary('BioFormats', 'CellomicsReader##SINGLE_IMAGE') registrationDetails = factory.createImageRegistrationDetails(imageDataset, incoming) transaction = service.transaction(incoming, factory) diff --git a/screening/source/core-plugins/screening/1/dss/drop-boxes/hcs-dropbox/hcs-dropbox.py b/screening/source/core-plugins/screening/1/dss/drop-boxes/hcs-dropbox/hcs-dropbox.py index 3d7bb8b77e0fbc5f513d45de661c204bec14c68b..1b29942bbe63241f489487f95f6aff85b1e55909 100644 --- a/screening/source/core-plugins/screening/1/dss/drop-boxes/hcs-dropbox/hcs-dropbox.py +++ b/screening/source/core-plugins/screening/1/dss/drop-boxes/hcs-dropbox/hcs-dropbox.py @@ -79,7 +79,6 @@ def process(transaction): imageDataset.setRawImageDatasetType() imageDataset.setGenerateThumbnails(True) imageDataset.setUseImageMagicToGenerateThumbnails(False) - imageDataset.setPlate(SPACE_CODE, PLATE_CODE) plate = create_plate_if_needed(transaction) dataset = transaction.createNewImageDataSet(imageDataset, incoming); dataset.setSample(plate) diff --git a/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/BasicDataSetInformation.java b/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/BasicDataSetInformation.java index 84e475238305917f81b2015dc3e1b314abde5ed2..f1eadcc3e6952f44842659a8a45d7aeee3365654 100644 --- a/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/BasicDataSetInformation.java +++ b/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/BasicDataSetInformation.java @@ -18,6 +18,8 @@ package ch.systemsx.cisd.openbis.dss.etl.dto.api.v1; import java.util.Arrays; +import ch.systemsx.cisd.etlserver.registrator.api.v1.IDataSet; +import ch.systemsx.cisd.openbis.dss.generic.shared.api.internal.v1.ISampleImmutable; import ch.systemsx.cisd.openbis.dss.generic.shared.dto.DataSetInformation; import ch.systemsx.cisd.openbis.generic.shared.IServer; import ch.systemsx.cisd.openbis.generic.shared.basic.dto.DataSetType; @@ -50,7 +52,11 @@ public class BasicDataSetInformation extends DataSetInformation this.fileFormatTypeCode = fileFormatCode; } - /** Mandatory: sets attributes of the connected sample */ + /** + * @deprecated instead invoke {@link IDataSet#setSample(ISampleImmutable)} on the + * {@link IDataSet} object created. + */ + @Deprecated public void setSample(String sampleSpaceCode, String sampleCode) { super.setSpaceCode(sampleSpaceCode); diff --git a/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/SimpleImageDataConfig.java b/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/SimpleImageDataConfig.java index c68f5bd0a3723ee9cf2b148401a13522a44b8f69..e04efdff3eefed93e47c1c27cb7f7852c89794f9 100644 --- a/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/SimpleImageDataConfig.java +++ b/screening/source/java/ch/systemsx/cisd/openbis/dss/etl/dto/api/v1/SimpleImageDataConfig.java @@ -23,6 +23,7 @@ import java.util.List; import ch.systemsx.cisd.base.image.IImageTransformerFactory; import ch.systemsx.cisd.common.shared.basic.utils.StringUtils; +import ch.systemsx.cisd.etlserver.registrator.api.v1.IDataSet; import ch.systemsx.cisd.openbis.dss.etl.dto.ImageLibraryInfo; import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.thumbnails.DefaultThumbnailsConfiguration; import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.thumbnails.IThumbnailsConfiguration; @@ -31,6 +32,7 @@ import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.thumbnails.ZoomLevelBasedThum import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.transformations.ConvertToolImageTransformerFactory; import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.transformations.ImageTransformation; import ch.systemsx.cisd.openbis.dss.etl.dto.api.v1.transformations.ImageTransformationBuffer; +import ch.systemsx.cisd.openbis.dss.generic.shared.api.internal.v1.ISampleImmutable; import ch.systemsx.cisd.openbis.dss.generic.shared.utils.ImageUtil; import ch.systemsx.cisd.openbis.generic.shared.basic.CodeNormalizer; import ch.systemsx.cisd.openbis.plugin.screening.shared.api.v1.dto.Geometry; @@ -353,7 +355,10 @@ abstract public class SimpleImageDataConfig * * @param spaceCode space where the plate for which the dataset has been acquired exist * @param plateCode code of the plate to which the dataset will belong + * @deprecated instead invoke {@link IDataSet#setSample(ISampleImmutable)} on the + * {@link IDataSet} object created. */ + @Deprecated public void setPlate(String spaceCode, String plateCode) { this.spaceCode = spaceCode; diff --git a/screening/sourceTest/core-plugins/MiscellaneousDropBoxApiV2FeaturesTest/1/dss/drop-boxes/MiscellaneousDropBoxApiV2FeaturesTest-drop-box/data-set-handler.py b/screening/sourceTest/core-plugins/MiscellaneousDropBoxApiV2FeaturesTest/1/dss/drop-boxes/MiscellaneousDropBoxApiV2FeaturesTest-drop-box/data-set-handler.py index c37755c928034eae18ffc13feea5e92c81f0314b..2e7dab9bf93d580fc0bac66ff6f44e110ae6b0e4 100644 --- a/screening/sourceTest/core-plugins/MiscellaneousDropBoxApiV2FeaturesTest/1/dss/drop-boxes/MiscellaneousDropBoxApiV2FeaturesTest-drop-box/data-set-handler.py +++ b/screening/sourceTest/core-plugins/MiscellaneousDropBoxApiV2FeaturesTest/1/dss/drop-boxes/MiscellaneousDropBoxApiV2FeaturesTest-drop-box/data-set-handler.py @@ -78,7 +78,6 @@ def process(transaction): imageDataset.setRawImageDatasetType() imageDataset.setGenerateThumbnails(True) imageDataset.setUseImageMagicToGenerateThumbnails(False) - imageDataset.setPlate(SPACE_CODE, PLATE_CODE) dataset = transaction.createNewImageDataSet(imageDataset, incoming); plateGeometry = dataset.figureGeometry() plate = create_plate_if_needed(transaction, plateGeometry) diff --git a/screening/sourceTest/java/ch/systemsx/cisd/openbis/dss/screening/server/dropbox/hcs-simple-test.py b/screening/sourceTest/java/ch/systemsx/cisd/openbis/dss/screening/server/dropbox/hcs-simple-test.py index 4e760cacd0ec2c5fb01f81a8c92e48718b7c343d..0c120b21caf2b7ac4dac6024484ca45339432b43 100644 --- a/screening/sourceTest/java/ch/systemsx/cisd/openbis/dss/screening/server/dropbox/hcs-simple-test.py +++ b/screening/sourceTest/java/ch/systemsx/cisd/openbis/dss/screening/server/dropbox/hcs-simple-test.py @@ -64,7 +64,6 @@ def process(transaction): imageDataset.setRawImageDatasetType() imageDataset.setGenerateThumbnails(True) imageDataset.setUseImageMagicToGenerateThumbnails(False) - imageDataset.setPlate(SPACE_CODE, PLATE_CODE) plate = create_plate_if_needed(transaction) dataset = transaction.createNewImageDataSet(imageDataset, incoming); dataset.setSample(plate)